Fix Sentry capturing notFound as errors - #1191
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | 1a67335 | Commit Preview URL Branch Preview URL |
Aug 29 2026, 11:03 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where Sentry was reporting false positive errors due to TanStack Start's
notFound()control flow.TanStack Start uses
throw { isNotFound: true }as a mechanism to signal a 404 state, which is not a true error but a control flow. Sentry's server-side middleware was indiscriminately capturing these thrown objects as exceptions.The fix involves modifying
src/instrument.server.mjsto wrap thebeforeSendfunction. The wrapper now checks if the thrown exception (hint.originalException) has anisNotFoundproperty set totrue. If so, it returnsnull, preventing Sentry from reporting it as an error. Otherwise, it delegates to the originalredactByokRequestHeadersfunction.Fixes TANSTACK-COM-4QS
This PR was automatically generated by Sentry. You can adjust this setting at any time.