fix(table-core): toggle group column visibility#6442
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 08f6056
☁️ Nx Cloud last updated this comment at |
Summary
Why
Group columns already derive
getIsVisible()from their children, buttoggleVisibility()wrote the group ID intocolumnVisibility. Since visibility state is evaluated at the leaf level, that entry had no effect and the group remained visible. This keeps the existing leaf-based state model and makes the two group APIs consistent.Validation
pnpm nx run @tanstack/table-core:test:lib(52 files, 1006 tests)pnpm nx run @tanstack/table-core:test:typespnpm nx run @tanstack/table-core:test:eslintCloses #5497