Skip to content

fix(table-core): toggle group column visibility#6442

Draft
KevinVandy wants to merge 1 commit into
betafrom
agent/fix-5497-group-visibility
Draft

fix(table-core): toggle group column visibility#6442
KevinVandy wants to merge 1 commit into
betafrom
agent/fix-5497-group-visibility

Conversation

@KevinVandy

Copy link
Copy Markdown
Member

Summary

  • apply group-column visibility changes to descendant leaf column IDs
  • preserve visibility for descendant columns that disable hiding
  • cover explicit and inferred group visibility toggles with regression tests

Why

Group columns already derive getIsVisible() from their children, but toggleVisibility() wrote the group ID into columnVisibility. Since visibility state is evaluated at the leaf level, that entry had no effect and the group remained visible. This keeps the existing leaf-based state model and makes the two group APIs consistent.

Validation

  • pnpm nx run @tanstack/table-core:test:lib (52 files, 1006 tests)
  • pnpm nx run @tanstack/table-core:test:types
  • pnpm nx run @tanstack/table-core:test:eslint
  • Prettier check for changed files

Closes #5497

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1989f241-a7a4-4542-bc95-8af27114e24e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent/fix-5497-group-visibility

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Jul 18, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 08f6056

Command Status Duration Result
nx affected --targets=test:eslint,test:sherif,t... ✅ Succeeded 8m 10s View ↗
nx run-many --targets=build --exclude=examples/** ✅ Succeeded 54s View ↗

☁️ Nx Cloud last updated this comment at 2026-07-18 00:42:22 UTC

@pkg-pr-new

pkg-pr-new Bot commented Jul 18, 2026

Copy link
Copy Markdown
More templates

@tanstack/alpine-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/alpine-table@6442

@tanstack/angular-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/angular-table@6442

@tanstack/angular-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/angular-table-devtools@6442

@tanstack/ember-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/ember-table@6442

@tanstack/lit-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/lit-table@6442

@tanstack/match-sorter-utils

npm i https://pkg.pr.new/TanStack/table/@tanstack/match-sorter-utils@6442

@tanstack/preact-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/preact-table@6442

@tanstack/preact-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/preact-table-devtools@6442

@tanstack/react-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/react-table@6442

@tanstack/react-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/react-table-devtools@6442

@tanstack/solid-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/solid-table@6442

@tanstack/solid-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/solid-table-devtools@6442

@tanstack/svelte-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/svelte-table@6442

@tanstack/table-core

npm i https://pkg.pr.new/TanStack/table/@tanstack/table-core@6442

@tanstack/table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/table-devtools@6442

@tanstack/vue-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/vue-table@6442

@tanstack/vue-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/vue-table-devtools@6442

commit: 08f6056

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Column visibility APIs do not work with column groups

1 participant