Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (251)
🚧 Files skipped from review as they are similar to previous changes (146)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughVite and related tooling were upgraded across workspace catalogs, benchmarks, end-to-end fixtures, examples, and packages. Start-plugin-core now supports Vite’s separate bundled development runtime. React Start RSC type export paths and e2e type validation were also updated. ChangesWorkspace catalog and runtime integration
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: ⚪ Minimal · up to This change updates the Vite toolchain and related declaration/runtime compatibility across examples and E2E fixtures. No concrete merge-blocking production risk is evidenced. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 5 files. (251 skipped: 251 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
package: react-router
package: router-utils
package: history
package: eslint-plugin-router
package: valibot-adapter
package: zod-adapter
package: solid-router
package: arktype-adapter
package: router-vite-plugin
package: react-start-server
package: react-start
package: react-start-client
package: solid-start-client
package: solid-start-server
package: router-devtools-core
package: react-router-devtools
package: solid-start
package: solid-router-devtools
package: start-plugin-core
package: start-server-core
package: start-client-core
package: virtual-file-routes
package: start-static-server-functions
package: start-storage-context
package: react-router-ssr-query
package: solid-router-ssr-query
package: vue-router
labels
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
🚀 Changeset Version Preview2 package(s) bumped directly, 3 bumped as dependents. 🟩 Patch bumps
|
Contributor
|
View your CI Pipeline Execution ↗ for commit d52f5b7
☁️ Nx Cloud last updated this comment at |
Contributor
Bundle Size Benchmarks
The following scenarios have bundle-size changes compared with the baseline:
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better. |
Merging this PR will degrade performance by 4.52%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Memory | mem server peak-large-page (react) |
415.9 KB | 493.4 KB | -15.7% |
| ❌ | Simulation | ssr control-flow unmatched 404 (react) |
202.1 ms | 227 ms | -10.94% |
| ❌ | Simulation | ssr not-found (react) |
170.4 ms | 186.4 ms | -8.57% |
| ❌ | Simulation | ssr control-flow unmatched 404 (solid) |
212.7 ms | 229.4 ms | -7.26% |
| ❌ | Simulation | ssr control-flow route headers (solid) |
288.7 ms | 307.2 ms | -6.02% |
| ❌ | Simulation | ssr control-flow route headers (react) |
276.3 ms | 292.5 ms | -5.53% |
| ❌ | Simulation | ssr assets linked-css control (react) |
213.7 ms | 225.5 ms | -5.24% |
| ❌ | Simulation | ssr assets inline-css cdn (react) |
212.3 ms | 223.7 ms | -5.1% |
| ❌ | Simulation | ssr control-flow error 500 (react) |
201.8 ms | 211.3 ms | -4.47% |
| ❌ | Simulation | ssr not-found (solid) |
179 ms | 186.8 ms | -4.16% |
| ❌ | Simulation | ssr rewrite passthrough (react) |
197.1 ms | 204.6 ms | -3.66% |
| ❌ | Simulation | ssr rewrite localized (react) |
207.8 ms | 215.3 ms | -3.51% |
| ❌ | Simulation | ssr dehydrate plain control (react) |
218 ms | 225.3 ms | -3.26% |
| ❌ | Memory | mem server server-fn-churn (vue) |
233.6 KB | 241.4 KB | -3.23% |
| ❌ | Simulation | ssr dehydrate rich types (react) |
219.8 ms | 227.1 ms | -3.22% |
| ⚡ | Memory | mem server peak-large-page (solid) |
449.9 KB | 369.5 KB | +21.76% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing codex/update-vite-vitest (d52f5b7) with main (6494e75)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Update the Vite build and test toolchain across packages, benchmarks, examples, and e2e fixtures. Version selection uses pnpm 11.21.0 with the workspace's existing one-day
minimumReleaseAgeandtrustPolicy: no-downgradesettings. An exactminimumReleaseAgeExcludeentry permitsvite@8.3.0immediately because it includes the bundled-dev runtime fix.Dependency rules
catalog:for Vite, Vitest, and Vite plugin devDependencies outsideexamples/ande2e/.@vitejs/*,vite-plugin-*, scoped plugins, and plugin entry points such asnitro/viteand Paraglide's Vite integration. Regenerate the lockfile for these changes.Updated versions
vitevitest,@vitest/ui@vitejs/plugin-react@vitejs/plugin-rsc@vitejs/plugin-vue@vitejs/plugin-vue-jsxvite-plugin-solidvite-plugin-dts@tanstack/vite-config@cloudflare/vite-plugin@tailwindcss/vite@sentry/vite-plugin@rolldown/plugin-babel@inlang/paraglide-jsnitro@codspeed/vitest-pluginwranglerThe shared Vite config is updated alongside the declaration plugin, and the
vite-plugin-dtsoverride moves from 4.2.3 to 5.1.0 so it no longer forces the old implementation. Wrangler is updated in the six Cloudflare projects to satisfy the new Cloudflare plugin's^4.130.0peer requirement. CodSpeed 5.7.1 brings macOS support and profiling fixes since 5.5.0. Nitro continues on its existing beta release stream.The React, Solid, and Vue Start server-entry declaration configs also drop their source-path aliases. Their main server exports are already built before the server-entry build runs. Resolving those public exports directly keeps the declaration imports intact with
vite-plugin-dts5; retaining the aliases rewrote them to a nonexistent../server.tsxand broke contextual typing in the SSR asset benchmarks. Those three consumer type checks and Start package export checks pass with the adjustment.The declaration migration also updates the E2E utilities to the renamed
outDirsoption and aligns React Start RSC type exports with the newdist/esm/layout. The E2E utilities now have a type-check target that checks the build config and consumes the exported Playwright fixture types, catching missing declarations before they cascade into app builds and browser tests. A patch changeset covers the RSC export paths.Start's dev manifest now loads Vite's separate bundled-dev runtime before the client entry on Vite 8.2.1 and later. Without it, the browser fails with
__rolldown_runtime__ is not defined, preventing hydration, HMR, and client-side import-protection diagnostics. Start also waits for client rebuilds through Vite's newbundledDev.devEnginelocation before rendering SSR, preventing stale client bundles and hydration mismatches after edits. Earlier Vite versions retain their embedded-runtime startup path and legacy dev-engine access. Regression coverage checks both paths and a non-root public base; a patch changeset covers this runtime fix.Vite 8.3.0 includes the upstream bundled-dev runtime fix for modules without exports. The repository uses the published package directly without dependency patches. The release-age exception is scoped to
vite@8.3.0; other packages retain the normal delay and trust checks.Versions deliberately held back
benchAPI used by the existing benchmarks, so Vitest and its UI stay on the latest v4 release, 4.1.11.@netlify/vite-plugin-tanstack-start: retain the existing^1.1.4manifest range and locked 1.1.4. Updating to 1.3.19 failed pnpm's trust check because its dependency chain pulls@netlify/serverless-functions-api@2.18.0, which has lower trust evidence than earlier releases. No trust-policy exceptions were added.Validation
With unpatched Vite 8.3.0 and the Start compatibility fixes:
pnpm test:eslint,pnpm test:types, andpnpm test:unitpassed, including their required package builds.✅ Checklist
🚀 Release Impact
Summary by CodeRabbit