chore(*): declare 'npm-run-all2' once in the root 'package.json' like other shared tools by sukvvon · Pull Request #11710 · TanStack/query

sukvvon · 2026-09-28T02:58:54Z

🎯 Changes

Add npm-run-all2 to devDependencies in the root package.json, next to the other shared tools such as premove, vitest, tsdown, and publint.
Remove npm-run-all2 from devDependencies of the 26 packages that run npm-run-all in test:types. They now use the binary from the root.
Update pnpm-lock.yaml.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Chores
- Centralized a shared development tool dependency at the repository level, reducing duplicated dependency entries across packages. No end-user functionality changes.

… other shared tools

nx-cloud · 2026-09-28T02:59:24Z

View your CI Pipeline Execution ↗ for commit 64f87a6

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	4m 34s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	36s	View ↗

☁️ Nx Cloud last updated this comment at 2026-09-28 03:04:54 UTC

github-actions · 2026-09-28T02:59:47Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

coderabbitai · 2026-09-28T03:00:15Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: e8a89040-db57-4035-9cf2-8893aca6a5c1

📥 Commits

Reviewing files that changed from the base of the PR and between 6b95f2f and 64f87a6.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (27)

package.json
packages/angular-query-experimental/package.json
packages/angular-query-persist-client/package.json
packages/eslint-plugin-query/package.json
packages/lit-query/package.json
packages/preact-query-devtools/package.json
packages/preact-query-persist-client/package.json
packages/preact-query/package.json
packages/query-async-storage-persister/package.json
packages/query-broadcast-client-experimental/package.json
packages/query-core/package.json
packages/query-devtools/package.json
packages/query-persist-client-core/package.json
packages/query-sync-storage-persister/package.json
packages/query-test-utils/package.json
packages/react-query-devtools/package.json
packages/react-query-next-experimental/package.json
packages/react-query-persist-client/package.json
packages/react-query/package.json
packages/solid-query-devtools/package.json
packages/solid-query-persist-client/package.json
packages/solid-query/package.json
packages/svelte-query-devtools/package.json
packages/svelte-query-persist-client/package.json
packages/svelte-query/package.json
packages/vue-query-devtools/package.json
packages/vue-query/package.json

💤 Files with no reviewable changes (26)

packages/react-query/package.json
packages/solid-query-devtools/package.json
packages/vue-query/package.json
packages/query-devtools/package.json
packages/preact-query-devtools/package.json
packages/lit-query/package.json
packages/query-broadcast-client-experimental/package.json
packages/solid-query-persist-client/package.json
packages/query-async-storage-persister/package.json
packages/preact-query/package.json
packages/query-sync-storage-persister/package.json
packages/query-core/package.json
packages/react-query-persist-client/package.json
packages/query-test-utils/package.json
packages/svelte-query-persist-client/package.json
packages/vue-query-devtools/package.json
packages/query-persist-client-core/package.json
packages/solid-query/package.json
packages/svelte-query/package.json
packages/react-query-next-experimental/package.json
packages/svelte-query-devtools/package.json
packages/angular-query-persist-client/package.json
packages/angular-query-experimental/package.json
packages/eslint-plugin-query/package.json
packages/react-query-devtools/package.json
packages/preact-query-persist-client/package.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

📝 Walkthrough

Walkthrough

The root package adds npm-run-all2 as a development dependency. Twenty-six package manifests remove the same dependency. The react-query-devtools test:types script retains its npm-run-all invocation.

Changes

Development dependency declarations

Layer / File(s)	Summary
Centralize `npm-run-all2` declaration `package.json`, `packages/*/package.json`	The root manifest adds `npm-run-all2` at `^9.0.3`. Package manifests remove their `npm-run-all2` declarations. The `react-query-devtools` `test:types` script still invokes `npm-run-all`.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: lachlancollins

Merge Risk: ⚪ Minimal · up to 64f87

This change centralizes a development tool; the affected workspace script resolved it successfully, and no concrete merge-blocking regression is established.

Architecture Summary

Architecture risk: 🔵 Low · up to 64f87

The change affects 27 systems.

Changed systems: package.json, packages/angular-query-experimental, packages/angular-query-persist-client, packages/eslint-plugin-query, packages/lit-query, packages/preact-query, packages/preact-query-devtools, packages/preact-query-persist-client, packages/query-async-storage-persister, packages/query-broadcast-client-experimental, packages/query-core, packages/query-devtools, packages/query-persist-client-core, packages/query-sync-storage-persister, packages/query-test-utils, packages/react-query, packages/react-query-devtools, packages/react-query-next-experimental, packages/react-query-persist-client, packages/solid-query, packages/solid-query-devtools, packages/solid-query-persist-client, packages/svelte-query, packages/svelte-query-devtools, packages/svelte-query-persist-client, packages/vue-query, packages/vue-query-devtools

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

observed — package.json (service) was modified; 1 changed file maps to changed impact.
observed — packages/angular-query-experimental (library) was modified; 1 changed file maps to changed impact.
observed — packages/angular-query-persist-client (library) was modified; 1 changed file maps to changed impact.
observed — packages/eslint-plugin-query (library) was modified; 1 changed file maps to changed impact.

Before / after behavior

observed — Modified behavior in package.json: Added npm-run-all2 (^9.0.3) to the root development dependencies.
observed — Modified behavior in packages/angular-query-experimental/package.json: Removed npm-run-all2 (^9.0.3) from devDependencies.
observed — Modified behavior in packages/angular-query-persist-client/package.json: Removed the npm-run-all2 development dependency (^9.0.3).
observed — Modified behavior in packages/eslint-plugin-query/package.json: Removed npm-run-all2 (^9.0.3) from the package’s devDependencies.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly states that `npm-run-all2` is declared once in the root `package.json` as a shared tool. It accurately summarizes the primary change.
Description check	✅ Passed	The description covers the dependency changes, affected packages, lockfile update, checklist, testing, AI policy, and release impact. It matches the required template and identifies the change as deve…
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-09-28T03:01:10Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11710

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11710

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11710

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11710

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11710

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11710

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11710

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11710

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11710

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11710

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11710

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11710

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11710

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11710

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11710

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11710

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11710

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11710

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11710

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11710

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11710

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11710

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11710

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11710

commit: 64f87a6

github-actions · 2026-09-28T03:02:16Z

size-limit report 📦

Path	Size
react full	11.73 KB (0%)
react minimal	8.58 KB (0%)

chore(*): declare 'npm-run-all2' once in the root 'package.json' like…

64f87a6

… other shared tools

sukvvon self-assigned this Sep 28, 2026

sukvvon merged commit 2e1ad64 into main Sep 28, 2026
9 checks passed

sukvvon deleted the chore/npm-run-all2-to-root branch September 28, 2026 04:13

Navigation Menu

Uh oh!

chore(*): declare 'npm-run-all2' once in the root 'package.json' like other shared tools - #11710

chore(*): declare 'npm-run-all2' once in the root 'package.json' like other shared tools#11710
sukvvon merged 1 commit into
mainfrom
chore/npm-run-all2-to-root

sukvvon commented Sep 28, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

nx-cloud Bot commented Sep 28, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 28, 2026

Uh oh!

coderabbitai Bot commented Sep 28, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

pkg-pr-new Bot commented Sep 28, 2026

Uh oh!

github-actions Bot commented Sep 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sukvvon commented Sep 28, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

nx-cloud Bot commented Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 28, 2026

🚀 Changeset Version Preview

Uh oh!

coderabbitai Bot commented Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Architecture Summary

Uh oh!

pkg-pr-new Bot commented Sep 28, 2026

Uh oh!

github-actions Bot commented Sep 28, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Sep 28, 2026 •

edited by coderabbitai Bot

Loading

nx-cloud Bot commented Sep 28, 2026 •

edited

Loading

coderabbitai Bot commented Sep 28, 2026 •

edited

Loading