chore(lit-query): remove unused package-specific scripts and 'scripts' directory by sukvvon · Pull Request #11701 · TanStack/query

sukvvon · 2026-09-27T14:23:46Z

🎯 Changes

Remove the lint:fix, test:watch, measure:bundle, measure:bundle:raw, perf:l3, and perf:l3:raw scripts from packages/lit-query/package.json, and delete the packages/lit-query/scripts directory (measure-bundle.mjs, l3-stress.mjs) they ran.
These scripts are not referenced by CI, docs, or other packages, and no other adapter has them (test:watch duplicates test:lib:dev).
Move devDependencies before peerDependencies to match the field order of the other adapters.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Chores

Removed commands for automatic lint fixes, watch-mode testing, bundle-size measurement, and performance stress testing. Build and test-build commands remain available.
Reordered dependency entries without changing their contents. The package’s public API remains unchanged.

nx-cloud · 2026-09-27T14:24:09Z

View your CI Pipeline Execution ↗ for commit 6d420c6

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	1m 30s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	2s	View ↗

☁️ Nx Cloud last updated this comment at 2026-09-28 04:17:29 UTC

github-actions · 2026-09-27T14:24:38Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

coderabbitai · 2026-09-27T14:26:06Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: e2a02c80-cace-4d15-9bfe-77d1b24f3f86

📥 Commits

Reviewing files that changed from the base of the PR and between f3187a6 and 67cf5c5.

📒 Files selected for processing (1)

packages/lit-query/package.json

🚧 Files skipped from review as they are similar to previous changes (1)

packages/lit-query/package.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

Walkthrough

The lit-query package manifest removes several utility scripts. The L3 stress-test and bundle-measurement scripts are deleted. Dependency declarations are reordered, with names and version specifications unchanged.

Changes

Lit Query Script Cleanup

Layer / File(s)	Summary
Remove package utility scripts `packages/lit-query/package.json`, `packages/lit-query/scripts/*`	The manifest removes the lint-fix, test-watch, bundle-measurement, and L3 performance scripts. The L3 stress-test and bundle-measurement scripts are deleted. Dependency declarations are reordered without changes to names or version specifications.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: tkdodo

Merge Risk: ⚪ Minimal · up to 67cf5

No supported workflow is shown to depend on the removed scripts. The cleanup is mergeable after normal checks.

Architecture Summary

Architecture risk: 🔵 Low · up to f3187

The change affects 1 system.

Changed systems: packages/lit-query

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

observed — packages/lit-query (library) was modified; 3 changed files map to changed impact.

Before / after behavior

observed — Modified behavior in packages/lit-query/scripts/l3-stress.mjs: The stress-test script was removed, including its controller host, query-cycle observer-count checks, memory and timing report, and error handler that logged failures and exited with status 1.
observed — Modified behavior in packages/lit-query/scripts/measure-bundle.mjs: The bundle-measurement script was removed, including its size calculations, JSON output, and error handling that logged failures and exited with status 1.
observed — Modified behavior in packages/lit-query/package.json: Removed the lint:fix script.
observed — Modified behavior in packages/lit-query/package.json: Removed test:watch, both bundle-measurement scripts, and both L3 performance scripts; test:build and build remain.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the removal of unused package-specific scripts and the scripts directory, which matches the main changes.
Description check	✅ Passed	The description explains the changes and motivation, completes all checklist items, and identifies the change as dev-only with no release impact.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-09-27T14:27:25Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11701

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11701

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11701

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11701

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11701

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11701

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11701

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11701

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11701

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11701

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11701

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11701

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11701

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11701

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11701

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11701

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11701

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11701

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11701

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11701

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11701

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11701

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11701

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11701

commit: 6d420c6

github-actions · 2026-09-27T14:27:35Z

size-limit report 📦

Path	Size
react full	11.73 KB (0%)
react minimal	8.58 KB (0%)

…' directory

…endencies' like other adapters

KevinVandy · 2026-09-27T19:34:10Z

why would lint:fix be removed?

sukvvon · 2026-09-28T00:51:21Z

@KevinVandy It was the only package with lint:fix, so I dropped it for consistency for now, and I'll look into adding it to all adapters later.

# Conflicts: # packages/lit-query/package.json

sukvvon requested a review from a team as a code owner September 27, 2026 14:23

sukvvon self-assigned this Sep 27, 2026

sukvvon added 2 commits September 28, 2026 00:51

chore(lit-query): remove unused package-specific scripts and 'scripts…

1a5e91b

…' directory

chore(lit-query/package.json): move 'devDependencies' before 'peerDep…

43c1b95

…endencies' like other adapters

sukvvon force-pushed the chore/lit-query-scripts branch from d815b36 to 43c1b95 Compare September 27, 2026 15:51

sukvvon added 2 commits September 28, 2026 01:29

Merge branch 'main' into chore/lit-query-scripts

359d792

Merge branch 'main' into chore/lit-query-scripts

f3187a6

sukvvon added 5 commits September 28, 2026 10:05

Merge remote-tracking branch 'origin/main' into chore/lit-query-scripts

67cf5c5

# Conflicts: # packages/lit-query/package.json

Merge branch 'main' into chore/lit-query-scripts

4f76ab8

Merge branch 'main' into chore/lit-query-scripts

47324c6

Merge branch 'main' into chore/lit-query-scripts

45ffcab

Merge branch 'main' into chore/lit-query-scripts

6d420c6

sukvvon requested a review from KevinVandy September 28, 2026 09:23

KevinVandy approved these changes Sep 28, 2026

View reviewed changes

sukvvon merged commit 84ab643 into main Sep 28, 2026
9 checks passed

sukvvon deleted the chore/lit-query-scripts branch September 28, 2026 15:34

Navigation Menu

Uh oh!

chore(lit-query): remove unused package-specific scripts and 'scripts' directory - #11701

chore(lit-query): remove unused package-specific scripts and 'scripts' directory#11701
sukvvon merged 9 commits into
mainfrom
chore/lit-query-scripts

sukvvon commented Sep 27, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

nx-cloud Bot commented Sep 27, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 27, 2026

Uh oh!

coderabbitai Bot commented Sep 27, 2026 •

edited

Loading

Reviews paused

Walkthrough

Changes

Uh oh!

pkg-pr-new Bot commented Sep 27, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 27, 2026

Uh oh!

KevinVandy commented Sep 27, 2026

Uh oh!

sukvvon commented Sep 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

sukvvon commented Sep 27, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Chores

Uh oh!

nx-cloud Bot commented Sep 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 27, 2026

🚀 Changeset Version Preview

Uh oh!

coderabbitai Bot commented Sep 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

Architecture Summary

Uh oh!

pkg-pr-new Bot commented Sep 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 27, 2026

size-limit report 📦

Uh oh!

KevinVandy commented Sep 27, 2026

Uh oh!

sukvvon commented Sep 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sukvvon commented Sep 27, 2026 •

edited by coderabbitai Bot

Loading

nx-cloud Bot commented Sep 27, 2026 •

edited

Loading

coderabbitai Bot commented Sep 27, 2026 •

edited

Loading

pkg-pr-new Bot commented Sep 27, 2026 •

edited

Loading