Repository navigation
Conversation
…ator() TanStack Start deprecated the `inputValidator` server-fn builder method in favor of `validator` (identical signature). Rename every call site and doc reference across the example apps, the e2e harness, and the JSDoc/skill code samples, so the repo stops teaching the deprecated form. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 9224456 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
View your CI Pipeline Execution ↗ for commit 9224456
💡 With Ultracache enabled, Nx Cloud learns each task's file inputs in CI and uses them on later runs. Turn on Ultracache in workspace settings ↗ · Read docs ↗ ☁️ Nx Cloud last updated this comment at |
@tanstack/ai
@tanstack/ai-acp
@tanstack/ai-angular
@tanstack/ai-anthropic
@tanstack/ai-bedrock
@tanstack/ai-byteplus
@tanstack/ai-claude-code
@tanstack/ai-client
@tanstack/ai-cloudflare
@tanstack/ai-code-mode
@tanstack/ai-code-mode-snippets
@tanstack/ai-codex
@tanstack/ai-cohere
@tanstack/ai-compaction
@tanstack/ai-computer-local
@tanstack/ai-computer-playwright
@tanstack/ai-computer-sandbox
@tanstack/ai-computer-use
@tanstack/ai-devtools-core
@tanstack/ai-durable-stream
@tanstack/ai-effect
@tanstack/ai-elevenlabs
@tanstack/ai-event-client
@tanstack/ai-fal
@tanstack/ai-gemini
@tanstack/ai-grok
@tanstack/ai-grok-build
@tanstack/ai-groq
@tanstack/ai-harness
@tanstack/ai-harness-cli
@tanstack/ai-isolate-cloudflare
@tanstack/ai-isolate-daytona
@tanstack/ai-isolate-e2b
@tanstack/ai-isolate-node
@tanstack/ai-isolate-quickjs
@tanstack/ai-isolate-quickjs-bun
@tanstack/ai-llmgateway
@tanstack/ai-lovable
@tanstack/ai-mcp
@tanstack/ai-memory
@tanstack/ai-meshy
@tanstack/ai-mistral
@tanstack/ai-muse
@tanstack/ai-neon
@tanstack/ai-octane
@tanstack/ai-ollama
@tanstack/ai-ollaya
@tanstack/ai-openai
@tanstack/ai-opencode
@tanstack/ai-openrouter
@tanstack/ai-optimize
@tanstack/ai-perplexity
@tanstack/ai-persistence
@tanstack/ai-preact
@tanstack/ai-react
@tanstack/ai-reactor
@tanstack/ai-remix
@tanstack/ai-sandbox
@tanstack/ai-sandbox-blaxel
@tanstack/ai-sandbox-boxd
@tanstack/ai-sandbox-cloudflare
@tanstack/ai-sandbox-daytona
@tanstack/ai-sandbox-docker
@tanstack/ai-sandbox-e2b
@tanstack/ai-sandbox-local-process
@tanstack/ai-sandbox-railway
@tanstack/ai-sandbox-sprites
@tanstack/ai-sandbox-upstash-box
@tanstack/ai-sandbox-vercel
@tanstack/ai-skills
@tanstack/ai-solid
@tanstack/ai-svelte
@tanstack/ai-typesafe
@tanstack/ai-uthana
@tanstack/ai-utils
@tanstack/ai-vercel-compat
@tanstack/ai-vercel-gateway
@tanstack/ai-vertex
@tanstack/ai-vue
@tanstack/ai-worldlabs
@tanstack/openai-base
@tanstack/preact-ai-devtools
@tanstack/react-ai-devtools
@tanstack/solid-ai-devtools
@tanstack/svelte-ai-devtools
commit: |
Coverage✅ Coverage held across 79 compared package(s). Each package is measured twice in this job — on this PR and on its merge-base with
|
TanStack Start deprecated the
inputValidatorserver-fn builder method in favor ofvalidator(identical signature). This renames every.inputValidator(call site and doc sample in the repo, so the codebase stops teaching the deprecated form.🎯 Changes
Renamed
createServerFn().inputValidator(...)to.validator(...)across:ts-react-chat,ts-react-media,ts-react-rerank,react/evaluate).testing/e2e).@tanstack/aiand@tanstack/ai-persistence, and theai-coreskill doc.docs/(server-functions, persistence, media, and the generatedreplayRunStreamreference).No runtime behavior changes.
validatorandinputValidatorhave the same signature.✅ Checklist
pnpm run test:pr, or these tests do not apply to this pull request.docs/for this change, or this change is not user-facing.pnpm changeset), or this PR does not change a published package.🚀 Release Impact
Testing
Commands run.
pnpm test:pr. Every target for the changed projects passed:test:types,build,test:oxlint,test:docs,test:kiira,test:lib. One unrelated failure:@tanstack/ai-sandbox-cloudflare:test:lib, a container-checkpoint test that shells out tochmodand fails on macOS (BSDchmodrejects the--it passes). This diff does not touch that package. It only ran because a JSDoc edit in@tanstack/aimarks downstream packages as affected. CI runs on Linux, where GNUchmodaccepts the call.Manual test.
grep -rn "inputValidator" --include="*.ts" --include="*.tsx" --include="*.md" . | grep -v node_modules | grep -v /dist/returns nothing.pnpm --filter ts-react-chat test:typespasses (the largest set of renamed call sites).pnpm --filter ts-react-media dev) and run a generation. The server functions still validate input and run.How this PR makes testing easy. The change is a mechanical rename to an identical-signature method, so
test:typeson each example and the e2e harness covers every call site.Risk / rollback
Low.
validatoris the current, non-deprecated name for the same method. To undo, revert this PR.Summary by CodeRabbit
.validator()for input validation instead of the deprecated.inputValidator().