chore: clear the clippy warnings that were real (#32) - #99
Merged
Conversation
jspaezp
force-pushed
the
chore/fix-warnings
branch
2 times, most recently
from
August 28, 2026 04:11
0f93f64 to
1c98614
Compare
jspaezp
force-pushed
the
feat/source-id-text
branch
from
August 28, 2026 05:43
626dc91 to
52d84bd
Compare
12 of 19. The remaining 7 are all `too_many_arguments` and need a decision, not a rename -- see the PR description. - The three benchmark examples repeated `((f32,f32),(f32,f32),(f16,f16))` six times; each gets a `BenchQuery` alias. - `Diann`/`Skyline`/`SpectronautReadingError` had every variant suffixed `Error`, so a match arm read `DiannReadingError::IoError`. Dropped the suffix. - `DecoyMode::from_str` was an inherent method shadowing the `FromStr` trait, so `"reverse".parse()` did not work. It implements `FromStr` now. - `speclib_build_cli`'s digest loop hand-rolled a counter; it uses `enumerate`. `PossibleAggregator`'s variants also carried a redundant suffix, but they are a clap `ValueEnum`, so the variant names ARE the CLI values. Renamed with the strings pinned by `#[value(name = ...)]`, which the Carafe end-to-end test covers -- `--help` still offers exactly `point-intensity-aggregator`, `chromatogram-aggregator`, `spectrum-aggregator`.
jspaezp
force-pushed
the
chore/fix-warnings
branch
from
August 28, 2026 16:02
1c98614 to
03b19dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Twelve of the nineteen warnings; the other seven need a decision rather than an
edit.
Rebased onto
mainnow that #98 has merged, so this is a single commit again.One semantic fixup folded in: #98 added a test asserting on
DiannReadingError::DiannPrecursorParsingError, which this PR renames toPrecursorParsing. Git rebased cleanly and the breakage only showed up atcompile time.
Fixed
very_complex_typex6 -- the threetimscentroidbenchmark examples spelled((f32,f32),(f32,f32),(f16,f16))six times between them. Each gets aBenchQueryalias.
enum_variant_namesx3 --Diann/Skyline/SpectronautReadingErrorsuffixedevery variant with
Error, so a match arm readDiannReadingError::IoError.Suffix dropped.
should_implement_trait--DecoyMode::from_strwas an inherent methodshadowing the trait, so
"reverse".parse::<DecoyMode>()did not work at all. Itimplements
FromStrnow, and the one call site uses.parse().mut_range_bound--speclib_build_cli's digest loop hand-rolled a counternext to the iterator; it uses
enumerate.The one to look at
PossibleAggregator's variants carried the same redundant suffix, but it derivesclap's
ValueEnum, so the variant names are the CLI values. A plain renamewould have silently changed
--aggregatorfromchromatogram-aggregatortochromatogram.Renamed with the strings pinned by
#[value(name = "...")], so the surface isidentical and now stated rather than implied.
--helpstill offers exactlypoint-intensity-aggregator,chromatogram-aggregator,spectrum-aggregator,and the Carafe end-to-end test passes
chromatogram-aggregator, so a futurerename that forgets the pin fails a test instead of breaking a caller.
Not fixed: 7 x
too_many_argumentsFunctions of 8-10 parameters. Silencing them with
#[allow]would be suppression,and bundling all seven into config structs is a real refactor with real regression
risk -- so it wants a call rather than my guess. They split two ways:
PyElutionGroup::new(pyo3#[new])render_chromatogram_plot(egui)run_pipeline,execute_pipeline,process_single_fileprocess_and_serialize,build_entryHappy to do the config-struct refactor for the bottom five as a follow-up.