feat(ui): add hint icons to suggest boxes - #1475
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds hint icons to the suggest boxes to more clearly indicate the actions that will be performed when pressing Enter. A "normal" icon indicates that an item will be added/applied to the selected entries, while an outline with a "+" indicates that a new item will be created from the search query.
Note: I did not update the
tag_bar_search_match_greyed.pngdocs image with an icon because I'd like to either not include an icon or add specific "x" icons when attempting to add a tag that already exists on an entry, however this interaction is currently blocked by #1474.Tasks Completed