Implement CDN uploading#34
Conversation
|
Warning Review limit reached
Next review available in: 42 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR adds a CDN publishing pipeline for app files. release.py now computes a unified SDK version across manifests, writes it to sdk_version.txt, and embeds sdkVersion, a creation timestamp, and git commit hash into apps.json. A new script, upload-app-files.py, uploads files to Cloudflare R2 via boto3. Two composite GitHub Actions are updated/added: release-apps now outputs sdk_version, and a new publish-apps action installs dependencies and invokes the upload script using CDN credentials. main.yml gains a PublishApps job, gated to pushes on main, that depends on Bundle and passes the computed sdk_version and CDN secrets to publish-apps. Changes
Sequence Diagram(s)sequenceDiagram
participant Bundle
participant ReleaseScript as release.py
participant PublishApps
participant UploadScript as upload-app-files.py
participant R2 as Cloudflare R2
Bundle->>ReleaseScript: run release step
ReleaseScript->>ReleaseScript: check_and_get_sdk_version, get_git_commit_hash
ReleaseScript-->>Bundle: write sdk_version.txt, output sdk_version
Bundle-->>PublishApps: needs.Bundle.outputs.sdk_version
PublishApps->>UploadScript: run with sdk_version, CDN credentials
UploadScript->>R2: upload files to apps/{sdk_version}/{file_name}
R2-->>UploadScript: success or error
Related issues: None found in provided context. Related PRs: None found in provided context. Suggested labels: ci, enhancement Suggested reviewers: None found in provided context. 🐰 A rabbit hops the CDN trail, 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 8
🧹 Nitpick comments (1)
.github/actions/publish-apps/action.yml (1)
16-18: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winPin
boto3version.
pip install boto3with no version pin risks non-reproducible builds and silently picking up breaking changes over time.📌 Proposed fix
- run: pip install boto3 + run: pip install boto3==1.34.0 # pin to a known-good, tested version
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 8c3a410b-2cbd-495a-b827-746f8b6e282f
📒 Files selected for processing (5)
.github/actions/publish-apps/action.yml.github/actions/release-apps/action.yml.github/workflows/main.ymlBuildscripts/CDN/upload-app-files.pyrelease.py
Summary by CodeRabbit