Skip to content

Implement CDN uploading#34

Merged
KenVanHoeylandt merged 2 commits into
mainfrom
cdn-uploading
Jul 3, 2026
Merged

Implement CDN uploading#34
KenVanHoeylandt merged 2 commits into
mainfrom
cdn-uploading

Conversation

@KenVanHoeylandt

@KenVanHoeylandt KenVanHoeylandt commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features
    • Release artifacts now include clearer build metadata, including the SDK version, creation time, and source commit information.
    • App publishing is now automated in the main release flow after a successful build.
  • Bug Fixes
    • Added validation to prevent releasing apps that target different SDK versions in the same bundle.
    • Improved upload reliability for app deployment to the CDN.

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@KenVanHoeylandt, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 42 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bb4b2c58-5488-42ae-aa87-96689b967645

📥 Commits

Reviewing files that changed from the base of the PR and between ad081ea and 19d7a92.

📒 Files selected for processing (3)
  • .github/workflows/main.yml
  • Buildscripts/CDN/upload-app-files.py
  • release.py
📝 Walkthrough

Walkthrough

This PR adds a CDN publishing pipeline for app files. release.py now computes a unified SDK version across manifests, writes it to sdk_version.txt, and embeds sdkVersion, a creation timestamp, and git commit hash into apps.json. A new script, upload-app-files.py, uploads files to Cloudflare R2 via boto3. Two composite GitHub Actions are updated/added: release-apps now outputs sdk_version, and a new publish-apps action installs dependencies and invokes the upload script using CDN credentials. main.yml gains a PublishApps job, gated to pushes on main, that depends on Bundle and passes the computed sdk_version and CDN secrets to publish-apps.

Changes

Cohort / File(s) Change Summary
release.py Added check_and_get_sdk_version and get_git_commit_hash helpers; writes sdk_version.txt; expanded output_json with sdkVersion, created, gitCommit
Buildscripts/CDN/upload-app-files.py New script uploading app files to Cloudflare R2 via boto3, with CLI entrypoint, help text, and error handling
.github/actions/release-apps/action.yml Added sdk_version output sourced from the release step
.github/actions/publish-apps/action.yml New composite action downloading CDN artifacts and invoking the upload script
.github/workflows/main.yml Bundle job now outputs sdk_version; new PublishApps job runs on push to main, depending on Bundle

Sequence Diagram(s)

sequenceDiagram
  participant Bundle
  participant ReleaseScript as release.py
  participant PublishApps
  participant UploadScript as upload-app-files.py
  participant R2 as Cloudflare R2

  Bundle->>ReleaseScript: run release step
  ReleaseScript->>ReleaseScript: check_and_get_sdk_version, get_git_commit_hash
  ReleaseScript-->>Bundle: write sdk_version.txt, output sdk_version
  Bundle-->>PublishApps: needs.Bundle.outputs.sdk_version
  PublishApps->>UploadScript: run with sdk_version, CDN credentials
  UploadScript->>R2: upload files to apps/{sdk_version}/{file_name}
  R2-->>UploadScript: success or error
Loading

Related issues: None found in provided context.

Related PRs: None found in provided context.

Suggested labels: ci, enhancement

Suggested reviewers: None found in provided context.

🐰 A rabbit hops the CDN trail,
With boto3 tucked beneath its tail,
sdk_version passed with care,
From Bundle job to R2's lair,
Apps now published, without fail!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: adding CDN upload support via new release and publish actions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cdn-uploading

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 8

🧹 Nitpick comments (1)
.github/actions/publish-apps/action.yml (1)

16-18: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Pin boto3 version.

pip install boto3 with no version pin risks non-reproducible builds and silently picking up breaking changes over time.

📌 Proposed fix
-      run: pip install boto3
+      run: pip install boto3==1.34.0  # pin to a known-good, tested version

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8c3a410b-2cbd-495a-b827-746f8b6e282f

📥 Commits

Reviewing files that changed from the base of the PR and between 4ab2377 and ad081ea.

📒 Files selected for processing (5)
  • .github/actions/publish-apps/action.yml
  • .github/actions/release-apps/action.yml
  • .github/workflows/main.yml
  • Buildscripts/CDN/upload-app-files.py
  • release.py

Comment thread .github/actions/publish-apps/action.yml
Comment thread .github/actions/publish-apps/action.yml
Comment thread .github/actions/release-apps/action.yml
Comment thread .github/workflows/main.yml
Comment thread Buildscripts/CDN/upload-app-files.py
Comment thread Buildscripts/CDN/upload-app-files.py Outdated
Comment thread release.py
Comment thread release.py Outdated
@KenVanHoeylandt KenVanHoeylandt merged commit 71bf263 into main Jul 3, 2026
20 checks passed
@KenVanHoeylandt KenVanHoeylandt deleted the cdn-uploading branch July 3, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant