Remove TactilityCore

[KenVanHoeylandt]

Move TactilityCore code into Tactilty subproject

Summary by CodeRabbit

Summary by CodeRabbit

• New Features

  • Test/build naming now consistently uses the newer project/component names.

• Bug Fixes

  • Updated the CI test sequence and simulator/device build dependencies to match the current component layout.
  • Removed outdated build links to the former core component where applicable.

• Documentation

  • Refreshed documentation for the active test suites and architecture layer stack, and updated naming conventions.

• Chores

  • Removed the obsolete core component and its associated test executable, along with related license/readme content.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a9dfd795-1f12-44ca-a2f0-3fdaf4cba65e

📥 Commits

Reviewing files that changed from the base of the PR and between 657f4b0 and aa3eeaa.

📒 Files selected for processing (1)

• Documentation/README.md

---

📝 Walkthrough

Walkthrough

This pull request removes TactilityCore from the build and test configuration, updates dependent components to use Tactility or TactilityKernel, and renames the affected test targets. The CI workflow step order is adjusted, and the README is updated to match the new test list and architecture layout.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: removing the TactilityCore component and moving its code into Tactility.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch tactilitycore-removal

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (2)

Documentation/README.md (2)

1-1: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Document title doesn't match filename.

The file is Documentation/README.md but its top-level heading reads "# CLAUDE.md". This is confusing for a document intended to be the project's README.

As per coding guidelines, "Maintain comprehensive README.md documentation in the Documentation directory."

📝 Proposed fix

-# CLAUDE.md
+# README.md

Source: Coding guidelines

---

132-140: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Remove the stale TactilityCore reference from Coding Style. The C++ conventions line still lists TactilityCore, but the Layer Stack section no longer includes that module. Keep the module names consistent.

Source: Coding guidelines

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 66c9a7ac-c303-47bf-b58c-f8c2d3bd2dec

📥 Commits

Reviewing files that changed from the base of the PR and between dfaeb9a and 657f4b0.

📒 Files selected for processing (39)

• .github/workflows/tests.yml
• CMakeLists.txt
• Devices/m5stack-papers3/CMakeLists.txt
• Devices/simulator/CMakeLists.txt
• Documentation/README.md
• Drivers/PwmBacklight/CMakeLists.txt
• Firmware/CMakeLists.txt
• Modules/hal-device-module/CMakeLists.txt
• Tactility/CMakeLists.txt
• Tactility/Include/Tactility/Bundle.h
• Tactility/Include/Tactility/CoreDefines.h
• Tactility/Include/Tactility/CpuAffinity.h
• Tactility/Include/Tactility/StringUtils.h
• Tactility/Include/Tactility/TactilityCore.h
• Tactility/Include/Tactility/file/File.h
• Tactility/Include/Tactility/kernel/PanicHandler.h
• Tactility/Include/Tactility/kernel/Platform.h
• Tactility/Include/Tactility/kernel/SpiDeviceLock.h
• Tactility/Private/Tactility/kernel/critical/Critical.h
• Tactility/Source/Bundle.cpp
• Tactility/Source/CpuAffinity.cpp
• Tactility/Source/StringUtils.cpp
• Tactility/Source/file/File.cpp
• Tactility/Source/kernel/PanicHandler.cpp
• Tactility/Source/kernel/Platform.cpp
• Tactility/Source/kernel/critical/Critical.cpp
• TactilityC/CMakeLists.txt
• TactilityCore/CMakeLists.txt
• TactilityCore/LICENSE-GPL-3.0.md
• TactilityCore/README.md
• Tests/CMakeLists.txt
• Tests/Tactility/CMakeLists.txt
• Tests/Tactility/Source/BundleTest.cpp
• Tests/Tactility/Source/FileTest.cpp
• Tests/Tactility/Source/StringTest.cpp
• Tests/Tactility/Source/TestFile.h
• Tests/TactilityCore/CMakeLists.txt
• Tests/TactilityCore/Source/Main.cpp
• Tests/TactilityKernel/CMakeLists.txt

💤 Files with no reviewable changes (11)

• Tests/TactilityCore/CMakeLists.txt
• Tests/CMakeLists.txt
• TactilityCore/LICENSE-GPL-3.0.md
• Tests/TactilityCore/Source/Main.cpp
• TactilityC/CMakeLists.txt
• TactilityCore/README.md
• TactilityCore/CMakeLists.txt
• Tactility/CMakeLists.txt
• Devices/simulator/CMakeLists.txt
• Modules/hal-device-module/CMakeLists.txt
• CMakeLists.txt