Skip to content

Replaced Logger usage with LOG_x#548

Merged
KenVanHoeylandt merged 6 commits into
mainfrom
logger-replaced-by-kernel-log
Jul 4, 2026
Merged

Replaced Logger usage with LOG_x#548
KenVanHoeylandt merged 6 commits into
mainfrom
logger-replaced-by-kernel-log

Conversation

@KenVanHoeylandt

Copy link
Copy Markdown
Contributor

The template class Logger generated 161 functions, which is undesirable. I replaced it with the kernel logging functions.

@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Too many files!

This PR contains 162 files, which is 12 over the limit of 150.

To get a review, narrow the scope:
• coderabbit review --type committed # exclude uncommitted changes
• coderabbit review --dir # limit to a subdirectory
• coderabbit review --base # compare against a closer base

Upgrade to a paid plan to raise the limit.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b5e730b1-e311-4b64-a850-11e9c5f99683

📥 Commits

Reviewing files that changed from the base of the PR and between ecad224 and a728968.

📒 Files selected for processing (162)
  • Devices/cyd-4848s040c/Source/devices/St7701Display.cpp
  • Devices/guition-jc1060p470ciwy/Source/devices/Display.cpp
  • Devices/guition-jc1060p470ciwy/Source/devices/Jd9165Display.cpp
  • Devices/guition-jc1060p470ciwy/Source/devices/Power.cpp
  • Devices/guition-jc3248w535c/Source/Axs15231b/Axs15231bDisplay.cpp
  • Devices/lilygo-tdeck/Source/Init.cpp
  • Devices/lilygo-tdeck/Source/KeyboardBacklight/KeyboardBacklight.cpp
  • Devices/lilygo-tdeck/Source/Trackball/Trackball.cpp
  • Devices/lilygo-tdeck/Source/devices/TdeckKeyboard.cpp
  • Devices/lilygo-tdeck/Source/devices/TrackballDevice.cpp
  • Devices/lilygo-tdisplay-s3/Source/Init.cpp
  • Devices/lilygo-tdongle-s3/Source/Init.cpp
  • Devices/lilygo-thmi/Source/Init.cpp
  • Devices/lilygo-thmi/Source/devices/Power.cpp
  • Devices/lilygo-tlora-pager/Source/Init.cpp
  • Devices/lilygo-tlora-pager/Source/devices/TpagerEncoder.cpp
  • Devices/lilygo-tlora-pager/Source/devices/TpagerKeyboard.cpp
  • Devices/lilygo-tlora-pager/Source/devices/TpagerPower.cpp
  • Devices/m5stack-cardputer-adv/Source/devices/CardputerPower.cpp
  • Devices/m5stack-cardputer/Source/devices/CardputerKeyboard.cpp
  • Devices/m5stack-cardputer/Source/devices/CardputerPower.cpp
  • Devices/m5stack-cores3/Source/InitBoot.cpp
  • Devices/m5stack-cores3/Source/devices/Display.cpp
  • Devices/m5stack-papers3/Source/Init.cpp
  • Devices/m5stack-stackchan/Source/devices/Display.cpp
  • Devices/m5stack-tab5/Source/devices/Detect.cpp
  • Devices/m5stack-tab5/Source/devices/Display.cpp
  • Devices/m5stack-tab5/Source/devices/Ili9881cDisplay.cpp
  • Devices/m5stack-tab5/Source/devices/St7123Display.cpp
  • Devices/m5stack-tab5/Source/devices/St7123Touch.cpp
  • Devices/simulator/Source/Main.cpp
  • Devices/unphone/Source/InitBoot.cpp
  • Devices/unphone/Source/UnPhoneFeatures.cpp
  • Devices/unphone/Source/devices/Hx8357Display.cpp
  • Devices/waveshare-s3-touch-lcd-147/Source/Init.cpp
  • Devices/waveshare-s3-touch-lcd-147/Source/devices/Jd9853Display.cpp
  • Drivers/BQ24295/Source/Bq24295.cpp
  • Drivers/BQ25896/Source/Bq25896.cpp
  • Drivers/BQ27220/Source/Bq27220.cpp
  • Drivers/ButtonControl/Source/ButtonControl.cpp
  • Drivers/DRV2605/Source/Drv2605.cpp
  • Drivers/EspLcdCompat/Source/EspLcdDisplay.cpp
  • Drivers/EspLcdCompat/Source/EspLcdDisplayV2.cpp
  • Drivers/EspLcdCompat/Source/EspLcdSpiDisplay.cpp
  • Drivers/EspLcdCompat/Source/EspLcdTouch.cpp
  • Drivers/EspLcdCompat/Source/EspLcdTouchDriver.cpp
  • Drivers/EstimatedPower/Source/ChargeFromAdcVoltage.cpp
  • Drivers/EstimatedPower/Source/ChargeFromVoltage.cpp
  • Drivers/GC9A01/Source/Gc9a01Display.cpp
  • Drivers/GT911/Source/Gt911Touch.cpp
  • Drivers/ILI9488/Source/Ili9488Display.cpp
  • Drivers/PwmBacklight/Source/PwmBacklight.cpp
  • Drivers/RgbDisplay/Source/RgbDisplay.cpp
  • Drivers/SSD1306/Source/Ssd1306Display.cpp
  • Drivers/ST7735/Source/St7735Display.cpp
  • Drivers/ST7789-i8080/Source/St7789i8080Display.cpp
  • Drivers/ST7796-i8080/Source/St7796i8080Display.cpp
  • Drivers/ST7796/Source/St7796Display.cpp
  • Drivers/XPT2046SoftSPI/Source/Xpt2046SoftSpi.cpp
  • Modules/hal-device-module/source/hal/Device.cpp
  • Tactility/Include/Tactility/LogMessages.h
  • Tactility/Include/Tactility/network/EspHttpClient.h
  • Tactility/Private/Tactility/app/AppInstance.h
  • Tactility/Private/Tactility/json/Reader.h
  • Tactility/Source/PartitionsEsp.cpp
  • Tactility/Source/PreferencesEsp.cpp
  • Tactility/Source/Tactility.cpp
  • Tactility/Source/app/AppInstall.cpp
  • Tactility/Source/app/AppManifestParsing.cpp
  • Tactility/Source/app/AppManifestParsingV1.cpp
  • Tactility/Source/app/AppManifestParsingV2.cpp
  • Tactility/Source/app/AppRegistration.cpp
  • Tactility/Source/app/ElfApp.cpp
  • Tactility/Source/app/addgps/AddGps.cpp
  • Tactility/Source/app/alertdialog/AlertDialog.cpp
  • Tactility/Source/app/apphub/AppHubApp.cpp
  • Tactility/Source/app/apphub/AppHubEntry.cpp
  • Tactility/Source/app/apphubdetails/AppHubDetailsApp.cpp
  • Tactility/Source/app/apwebserver/ApWebServer.cpp
  • Tactility/Source/app/boot/Boot.cpp
  • Tactility/Source/app/btmanage/BtManage.cpp
  • Tactility/Source/app/btmanage/View.cpp
  • Tactility/Source/app/btpeersettings/BtPeerSettings.cpp
  • Tactility/Source/app/chat/ChatApp.cpp
  • Tactility/Source/app/chat/ChatSettings.cpp
  • Tactility/Source/app/crashdiagnostics/CrashDiagnostics.cpp
  • Tactility/Source/app/development/Development.cpp
  • Tactility/Source/app/display/Display.cpp
  • Tactility/Source/app/files/State.cpp
  • Tactility/Source/app/files/View.cpp
  • Tactility/Source/app/fileselection/State.cpp
  • Tactility/Source/app/fileselection/View.cpp
  • Tactility/Source/app/gpssettings/GpsSettings.cpp
  • Tactility/Source/app/i2cscanner/I2cScanner.cpp
  • Tactility/Source/app/imageviewer/ImageViewer.cpp
  • Tactility/Source/app/inputdialog/InputDialog.cpp
  • Tactility/Source/app/launcher/Launcher.cpp
  • Tactility/Source/app/notes/Notes.cpp
  • Tactility/Source/app/screenshot/Screenshot.cpp
  • Tactility/Source/app/selectiondialog/SelectionDialog.cpp
  • Tactility/Source/app/timedatesettings/TimeDateSettings.cpp
  • Tactility/Source/app/timezone/TimeZone.cpp
  • Tactility/Source/app/touchcalibration/TouchCalibration.cpp
  • Tactility/Source/app/webserversettings/WebServerSettings.cpp
  • Tactility/Source/app/wifiapsettings/WifiApSettings.cpp
  • Tactility/Source/app/wificonnect/View.cpp
  • Tactility/Source/app/wificonnect/WifiConnect.cpp
  • Tactility/Source/app/wifimanage/View.cpp
  • Tactility/Source/app/wifimanage/WifiManage.cpp
  • Tactility/Source/bluetooth/Bluetooth.cpp
  • Tactility/Source/bluetooth/BluetoothHidHost.cpp
  • Tactility/Source/bluetooth/BluetoothPairedDevice.cpp
  • Tactility/Source/bluetooth/BluetoothSettings.cpp
  • Tactility/Source/file/ObjectFileReader.cpp
  • Tactility/Source/file/ObjectFileWriter.cpp
  • Tactility/Source/file/PropertiesFile.cpp
  • Tactility/Source/hal/Hal.cpp
  • Tactility/Source/hal/gps/GpsDevice.cpp
  • Tactility/Source/hal/gps/GpsInit.cpp
  • Tactility/Source/hal/gps/Probe.cpp
  • Tactility/Source/hal/gps/Satellites.cpp
  • Tactility/Source/hal/gps/Ublox.cpp
  • Tactility/Source/hal/usb/Usb.cpp
  • Tactility/Source/hal/usb/UsbTusb.cpp
  • Tactility/Source/i18n/TextResources.cpp
  • Tactility/Source/kernel/SystemEvents.cpp
  • Tactility/Source/lvgl/Lvgl.cpp
  • Tactility/Source/lvgl/Statusbar.cpp
  • Tactility/Source/lvgl/UsbHidInput.cpp
  • Tactility/Source/network/Http.cpp
  • Tactility/Source/network/HttpServer.cpp
  • Tactility/Source/network/HttpdReq.cpp
  • Tactility/Source/network/Ntp.cpp
  • Tactility/Source/service/ServiceRegistration.cpp
  • Tactility/Source/service/development/DevelopmentService.cpp
  • Tactility/Source/service/development/DevelopmentSettings.cpp
  • Tactility/Source/service/displayidle/DisplayIdle.cpp
  • Tactility/Source/service/espnow/EspNow.cpp
  • Tactility/Source/service/espnow/EspNowService.cpp
  • Tactility/Source/service/espnow/EspNowWifi.cpp
  • Tactility/Source/service/gps/GpsConfiguration.cpp
  • Tactility/Source/service/gps/GpsService.cpp
  • Tactility/Source/service/gui/GuiService.cpp
  • Tactility/Source/service/loader/Loader.cpp
  • Tactility/Source/service/memorychecker/MemoryCheckerService.cpp
  • Tactility/Source/service/screenshot/Screenshot.cpp
  • Tactility/Source/service/screenshot/ScreenshotTask.cpp
  • Tactility/Source/service/statusbar/Statusbar.cpp
  • Tactility/Source/service/webserver/AssetVersion.cpp
  • Tactility/Source/service/webserver/WebServerService.cpp
  • Tactility/Source/service/wifi/WifiApSettings.cpp
  • Tactility/Source/service/wifi/WifiBootSplashInit.cpp
  • Tactility/Source/service/wifi/WifiEsp.cpp
  • Tactility/Source/service/wifi/WifiSettings.cpp
  • Tactility/Source/settings/Language.cpp
  • Tactility/Source/settings/SystemSettings.cpp
  • Tactility/Source/settings/WebServerSettings.cpp
  • TactilityC/Source/tt_app.cpp
  • TactilityCore/Include/Tactility/Logger.h
  • TactilityCore/Include/Tactility/TactilityCore.h
  • TactilityCore/Source/crypt/Crypt.cpp
  • TactilityCore/Source/file/File.cpp

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch logger-replaced-by-kernel-log

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@KenVanHoeylandt KenVanHoeylandt merged commit 9d59939 into main Jul 4, 2026
55 checks passed
Crazypedia added a commit to Crazypedia/Tactility-lilygo-tdeck-max that referenced this pull request Jul 5, 2026
Upstream TactilityProject#548 replaced tt::Logger with C-style LOG_x macros and TactilityProject#550
removed Tactility/Logger.h entirely. Convert our fork-only files
(CST3530, GDEQ031T10, and the lilygo-tdeck-max device sources) to match.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant