Repository navigation
chore(explain): accept @tabularis/explain 0.3 as peer - #65
Merged
Merged
Conversation
^0.2.0 only matches 0.2.x, so installing the parser next to @tabularis/explain 0.3.0 reports an unmet peer. The parser only uses registerExplainParser and the plan types, which 0.3.0 keeps compatible (parse/sniff may now also return a Promise, so the existing synchronous implementations still satisfy RegisteredExplainParser).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Widens the
peerDependenciesrange of the npm package inexplain/from^0.2.0to^0.2.0 || ^0.3.0.Why: for a 0.x version,
^0.2.0only matches 0.2.x. With@tabularis/explain0.3.0 (already used by explain.tabularis.dev), pnpm reports an unmet peer dependency for this parser.Compatibility: the parser only uses
registerExplainParserand the plan types. In 0.3.0,parse/sniffmay also return aPromise, so the current synchronous implementation still satisfiesRegisteredExplainParser. The parser already runs on 0.3.0 on explain.tabularis.dev (TabularisDB/explain-plan#17, 62/62 tests).Verification:
pnpm testandpnpm typecheckinexplain/pass, and the lockfile is unchanged.Reaches npm with the next plugin release.
🤖 Generated with Claude Code