fix: icon color matches badge background, making it invisible - #53
Merged
Conversation
…ible .tabularium sets the driver badge color to #336791, and the icon SVG used the same #336791 for fill/stroke, so the mark had zero contrast against its own badge. Switch the icon to white so it reads on the fixed badge background regardless of app theme.
aesslinger
added
the
prerelease:beta
Version suggestionBased on this PR's title (
This is informational only — no tag or release is created automatically yet. |
aesslinger
added a commit
that referenced
this pull request
Aug 25, 2026
Continuation of the beta line after PR #53 (driver icon rendered invisible because .tabularium's badge color and the icon SVG's fill/stroke were both #336791) and PR #50 (uuid 1.24.0 -> 1.24.1 patch bump, non-ASCII parse-diagnostics fix, no overlap with this plugin's v4 generation/serde usage). Verified: .tabularium re-validated as valid JSON; cargo build/test (114 unit + 8 live-DB against the local pg-tabularis-test container)/ clippy/fmt all pass; markdownlint clean on CHANGELOG.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.tabularium(#336791) is identical to the icon SVG'sfill/stroke(#336791), so the icon is invisible against its own badge on every connection using this driver.#ffffff), giving ~5.9:1 contrast against the fixed#336791badge background — passes WCAG AA and is unaffected by app light/dark theme since the badge color itself doesn't change with theme.Closes #52
Test plan