Repository navigation
fix(theme): draw the data grid header and selection in the theme's colors - #3837
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dataGrid.headerBackground,headerText,selection,inactiveSelection,selectionTextandfocusBorderare back, with their values in the 14 bundled themes, the Theme Editor's Selection section and the VS Code import mapping. refactor(data-grid)!: rebuild the macOS data grid on one model and native AppKit #3833 retired them and is unreleased, so no schema bump.ThemeFileFormat.retiredKeysis gone.ThemeTableHeaderCellpaints the band, divider and bottom line, then leaves the title and sort arrow to AppKit's interior drawing;ThemeTableHeaderViewstyles each title before a draw and bolds the highlighted column, which AppKit's highlight pass did.ThemeTableHeaderViewturns vibrancy off (measured with lldb on the running grid).3837.changed.mdnotes that a theme's missing header and selected text colors now take the system's.Test plan
TableProThemeTests157 pass.NSTableHeaderCellpaints and its 16 pt interior band, which title attributes AppKit honors, the copied filler cell, the highlight pass, and the header's vibrancy insideNSScrollPocket.Docs: TableProApp/docs#127