Repository navigation
perf(editor): build the query tab in AppKit and read the sidebar listing when the filter takes focus - #3834
Merged
Conversation
…ing when the filter takes focus
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EditorAreaController(history drawer) andQueryTabSplitController(editor over results) under one representable,EditorAreaHost, inMainEditorContentView. SwiftUI stays in the leaves: the command bar, the results, history and the other tab kinds.SQLEditorControllerreplacesSQLEditorViewand hosts the editor through TableProEditorKit's newSourceEditorHost, which reusesSourceEditor's coordinator, text and state sync and dismantle without a SwiftUI host around the editor.VerticalCollapsibleSplitView,QueryEditorViewandSQLEditorVieware removed.CollapsibleSplitControllerkeeps their collapse sync, autosave order and minimums.Measured on a Release build,
mainand this branch interleaved, machine load 12 to 14:Test plan
SourceEditorHostTests(sync both ways; a caret write does not swallow the next text; dismantle),EditorAreaControllerTests(another tab kind takes the editor down, a query tab switch keeps it; user collapse written back),SQLEditorCursorPropagationTests.editCaretReachesTheBinding,SidebarSchemaFilterTests(focus reads the listing once; Favorites reads none; a failed focus listing is not read again by the first keystroke),SidebarContainerChromeTestsfocus flag,DatabaseTreeReconcileTestsidle and loading render the same.QueryEditorViewLayoutTestsbecameQueryEditorPaneLayoutTests;SQLEditorCursorPropagationTestshostsSQLEditorController.Refs #3661