Skip to content

test(linux): retry a fixture's start when its image pull fails - #3828

Merged
datlechin merged 2 commits into
mainfrom
test/linux-fixture-pull-retry
Oct 24, 2026
Merged

datlechin merged 2 commits into
mainfrom
test/linux-fixture-pull-retry

Conversation

@datlechin

Copy link
Copy Markdown
Member

Summary

  • tablepro_test_fixtures::start_container takes a closure that builds the container request. When testcontainers reports that pulling the image failed, it builds and starts the request again, up to three times 5 seconds apart.
  • Every fixture and the OpenSSH session tests start their containers through it.
  • testcontainers pulls once. A Docker Hub pull cut short ("bytes remaining on stream") failed the mongo-7.0 Docker job twice in a few hours: on feat(linux): add the AI assistant #3822 and on main at c6eb271.
  • docs/testing.md, Docker or Podman, says so.

Test plan

  • New a_pull_that_keeps_failing_is_tried_three_times_and_reported (requires docker): an image tag that does not exist fails with the pull error after three attempts.
  • The fixtures' Postgres and OpenSSH tests and the 19 OpenSSH session tests pass through the helper.
  • clippy on both crates with -D warnings, cargo fmt --check.

@datlechin
datlechin enabled auto-merge (squash) October 24, 2026 17:42
@datlechin
datlechin merged commit 2f0a3ba into main Oct 24, 2026
36 checks passed
@datlechin
datlechin deleted the test/linux-fixture-pull-retry branch October 24, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant