Skip to content

[!!!][FEATURE] Share test instances between identically configured test cases #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bmack wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[!!!][FEATURE] Share test instances between identically configured test cases #740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e823075
[!!!][FEATURE] Share test instances between identically configured te…
bmack Jul 31, 2026
c5369a3
[FEATURE] Allow several test runs against one working copy
bmack Aug 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions Classes/Core/Functional/Framework/DataHandling/Snapshot/DatabaseSnapshot.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,18 @@ class DatabaseSnapshot
private static DatabaseSnapshot $instance;
private array $inMemoryImport = [];

public static function initialize(string $sqliteDir, string $identifier): void
/**
* @param string $identifier Identifies the *instance* database file, which several
* test case classes may share.
* @param string|null $snapshotIdentifier Identifies the snapshot taken of it. Defaults
* to $identifier for backwards compatibility, but callers
* sharing one instance between test case classes must pass a
* per test case value, otherwise one test case class restores
* the snapshot another one created.
*/
public static function initialize(string $sqliteDir, string $identifier, ?string $snapshotIdentifier = null): void
{
self::$instance = new self($sqliteDir, $identifier);
self::$instance = new self($sqliteDir, $identifier, $snapshotIdentifier ?? $identifier);
}

public static function instance(): self
Expand All @@ -50,11 +59,12 @@ public static function instance(): self

private function __construct(
private readonly string $sqliteDir,
private readonly string $identifier
private readonly string $identifier,
private readonly string $snapshotIdentifier
) {}

/**
* Create a new snapshot. This is called for the *first* test in a test case.
* Create a new snapshot. This is called for the *first* test of a test case class.
*/
public function create(DatabaseAccessor $accessor, Connection $connection): void
{
Expand All @@ -63,7 +73,7 @@ public function create(DatabaseAccessor $accessor, Connection $connection): void
$connection->close();
copy(
$this->sqliteDir . 'test_' . $this->identifier . '.sqlite',
$this->sqliteDir . 'test_' . $this->identifier . '.snapshot.sqlite'
$this->sqliteDir . 'test_' . $this->snapshotIdentifier . '.snapshot.sqlite'
);
$this->inMemoryImport = [true];
} else {
Expand All @@ -80,14 +90,14 @@ public function create(DatabaseAccessor $accessor, Connection $connection): void
}

/**
* Restore a snapshot. This is called for subsequent tests in a test case.
* Restore a snapshot. This is called for subsequent tests of a test case class.
*/
public function restore(DatabaseAccessor $accessor, Connection $connection): void
{
if ($connection->getDatabasePlatform() instanceof SQLitePlatform) {
$connection->close();
copy(
$this->sqliteDir . 'test_' . $this->identifier . '.snapshot.sqlite',
$this->sqliteDir . 'test_' . $this->snapshotIdentifier . '.snapshot.sqlite',
$this->sqliteDir . 'test_' . $this->identifier . '.sqlite'
);
} else {
Expand Down
Loading