Skip to content

Allow setting a seed for random numbers #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MaartenS11 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Allow setting a seed for random numbers #399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f6e5cf
Allow setting a seed for random numbers
MaartenS11 Aug 4, 2026
f1eb89e
Use std::minstd_rand instead of rand and srand because of an ESP-IDF …
MaartenS11 Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion platforms/Zephyr/prj.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ CONFIG_STM32_ENABLE_DEBUG_SLEEP_STOP=y
# Display drivers
CONFIG_DISPLAY=y

# Needed for random number generation primitives
CONFIG_ENTROPY_GENERATOR=y

# Needed for getting runtime memory stats
Expand Down
7 changes: 7 additions & 0 deletions src/Primitives/emulated.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,12 @@ def_prim(random_int, NoneToOneU32) {
return true;
}

def_prim(random_set_seed, oneToNoneI32) {
srand(arg0.uint32);
pop_args(1);
return true;
}

// call callback test function (temporary)
def_prim(test, oneToNoneU32) {
uint32_t fidx = arg0.uint32;
Expand Down Expand Up @@ -593,6 +599,7 @@ void install_primitives(Interpreter *interpreter) {
install_primitive(millis);
install_primitive(micros);
install_primitive(random_int);
install_primitive(random_set_seed);

install_primitive(print_int);
install_primitive(print_string);
Expand Down
15 changes: 13 additions & 2 deletions src/Primitives/zephyr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
#include <zephyr/drivers/gpio.h>
#include <zephyr/drivers/pwm.h>
#include <zephyr/kernel.h>
#include <zephyr/random/random.h>
#include <zephyr/sys/util_macro.h>

#if IS_ENABLED(CONFIG_WIFI)
Expand All @@ -32,6 +31,7 @@
#include <cstdio>
#include <cstring>
#include <optional>
#include <random>

#include "../Memory/mem.h"
#include "../Utils/macros.h"
Expand Down Expand Up @@ -176,8 +176,18 @@ def_prim(noTone, NoneToNoneU32) {

#endif

// Ideally, we would use rand and srand here but since ESP-IDF and Zephyr both
// define a function called "random" it causes a linker error.
static std::minstd_rand rng;

def_prim(random_int, NoneToOneU32) {
pushInt32(sys_rand32_get());
pushInt32(rng());
return true;
}

def_prim(random_set_seed, oneToNoneI32) {
rng.seed(arg0.uint32);
pop_args(1);
return true;
}

Expand Down Expand Up @@ -654,6 +664,7 @@ void install_primitives(Interpreter *interpreter) {
install_primitive(chip_digital_read);
install_primitive(millis);
install_primitive(random_int);
install_primitive(random_set_seed);
install_primitive(print_string);
install_primitive(print_int);
install_primitive(abort);
Expand Down
Loading