fix(data): fill sample requests across multiple epochs - #2365
Open
feng1201 wants to merge 1 commit into
Open
Conversation
Co-authored-by: OpenAI Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a request spans more than one dataset boundary,
RolloutDataSource.get_samplesonly wraps once. With three prompts,get_samples(8)returns six groups and storessample_offset=5; subsequent reads also diverge from the dataset stream.Read across as many epochs as needed, preserving epoch shuffling, group/sample indices, buffered samples, and checkpoint resume. Reject positive requests from an empty dataset so the loop cannot stall. The regression uses actual data-source classes, a JSONL file, and a locally saved Transformers tokenizer; no model download or mocked data-source implementation is needed. The test is included in the existing CPU CI matrix.
Validation:
python -m pytest tests/test_data_source.py tests/test_read_file_slicing.py tests/test_filter_long_prompt.py tests/test_sample.py -q— 52 passed.AI disclosure: implementation and local verification were performed with OpenAI Codex.