fix(rollout): reject aborted samples before reward tensor - #2361
Open
YeonwooSung wants to merge 1 commit into
Open
fix(rollout): reject aborted samples before reward tensor#2361YeonwooSung wants to merge 1 commit into
YeonwooSung wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #200.
Aborted samples keep
reward=None. On the default GRPO path that list was passed totorch.tensor, which crashes. Custom generate functions that abort (e.g. Search-R1 tool failure) hit this.This PR fail-closes instead of scoring those samples. We do not default
rewardto0.0. A previous attempt that did (#1252) was closed unmerged; aborted / unrewarded samples must not reach training.Change
In
RolloutManager._post_process_rewards, on the default path only (whencustom_reward_post_process_funcisNone), reject any sample withstatus == Sample.Status.ABORTEDorreward is Nonebeforeget_reward_value/torch.tensor.The error tells callers to filter in the generate function or recycle via partial rollout. Custom post-process keeps its own contract and is not subject to this check.
get_reward_valueisself.rewardorself.reward[args.reward_key]. Checkingreward is Nonefirst avoids aTypeErrorwhenreward_keyis set.Tests
tests/test_post_process_rewards.py(NUM_GPUS = 0) binds_post_process_rewardsonto a dummy object (no Ray):ABORTEDsample raisesValueErrorCOMPLETEDwithreward is NoneraisesValueError