fix(args): reject --kl-coef for GRPO-style estimators - #2359
Open
YeonwooSung wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--kl-coefis reward-KL shaping. GRPO-style estimators (grpo,gspo,cispo) do not apply KL to rewards, so a non-zero--kl-coefis a silent no-op today.This follows the maintainer decision on #399: we should not use KL in the GRPO reward, and should use
kl_lossinstead. #1247, which applied KL to GRPO rewards, was closed unmerged. This PR does not changeget_grpo_returns()or invent reward-KL math.slime_validate_argsnow raises a clearValueErrorwhen--kl-coef != 0is combined with--advantage-estimator {grpo,gspo,cispo}, and points users at--use-kl-loss/--kl-loss-coef.Test plan
python -m pytest tests/test_megatron_argument_validation.py -q --tb=shortgrpo/gspo/cispo+--kl-coef 0.1raiseValueErrormatchingkl-coef/kl-lossgrpo+--kl-coef 0still passesFixes #397