fix(whiten): scale-only path when shift_mean is false - #2356
Open
YeonwooSung wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1369.
distributed_masked_whiten(..., shift_mean=False)used to center, scale, then add the mean back:That is not a scale-only path. This change makes
shift_meando what it says:shift_mean=True(default):(values - global_mean) * rsqrt(global_var + epsilon)— zero-mean, unit-varianceshift_mean=False:values * rsqrt(global_var + epsilon)— scale only; do not subtract the mean, and do not add it backBoth paths still share the same Bessel-corrected global variance estimate.
The live GRPO caller in
slime/backends/megatron_utils/loss.pyalready usesshift_mean=True, so the production whitening path is unchanged.A CPU unit test (
NUM_GPUS = 0) mockstorch.distributed.all_reduceas a no-op so it can run without a process group, and pins the two formulas plus the shared variance.