docs: fix flag help and fault-tolerance default values - #2355
Open
YeonwooSung wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align help strings and published docs with the current code. No runtime behavior changes.
Fault-tolerance docs disagree with code defaults
docs/en/advanced/fault-tolerance.mdanddocs/zh/advanced/fault-tolerance.mdlisted stale health-check defaults.slime/utils/arguments.py)--rollout-health-check-first-wait--rollout-health-check-interval--rollout-health-check-timeoutThe example still sets
--rollout-health-check-first-wait 600as an override for large-model kernel compilation, not as the default.--disable-rollout-global-datasethelp is invertedaction="store_false"/dest="rollout_global_dataset"means passing the flag disables the global dataset.--prompt-data... If not set, you need to manage the data by your self."--prompt-dataas a global prompt dataset. If this flag is set, you manage data yourself (no global dataset).--kl-loss-typehelp advertises invalidklkl, k2, k3, low_var_klk1, k2, k3, low_var_kl(defaultk1), matchingchoices.CONTRIBUTING.md published doc URLs 404
Fixed both EN and ZH sections:
speculative_decoding.html→ https://thudm.github.io/slime/en/advanced/speculative-decoding.htmllow_precision_training.html→ https://thudm.github.io/slime/en/advanced/low-precision.htmlreproducibility.htmlwas already correct