[profiling] Add trainer communication timeline - #2353
Open
0z5a wants to merge 3 commits into
Open
Conversation
0z5a
force-pushed
the
codex/trainer-communication-timeline
branch
from
September 4, 2026 15:35
e113e1a to
b976717
Compare
Signed-off-by: 0z5a <dinadegttyarenko6@gmail.com>
Reuse a stateless disabled phase and bypass clocks, torch/CUDA events, context updates, bucket-size scans, serialization, files, and synchronization when the communication timeline is off. Add negative-path tests and document separate overhead modes. Assisted-by: OpenAI Codex Signed-off-by: 0z5a <dezhen.lu@student.uni-tuebingen.de>
0z5a
marked this pull request as ready for review
September 7, 2026 09:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft update — 2026-09-05
Labels CUDA-event timing as event brackets rather than kernel-observed timestamps, and removes disabled-timeline hot-path work. The targeted timeline follow-up passed 10 tests. No new full Ray/SGLang GPU run or cross-rank clock-calibration claim is made.
AI assistance: OpenAI Codex. Remains Draft; implementation, CPU/Gloo checks and production GPU validation are separate acceptance gates. No new GPU results were generated during publication.
The original submission description and validation history follow.
Summary
slime.observability, with semantic JSONL records, CUDA-event timing, and optional NVTX rangesRebase and duplicate audit
This draft is rebased onto
mainat4c193f1f. Conflict resolution preserves the current accelerator abstraction, weight-updater factory, and observability refactor.The newer
slime.observability.trace_utilsimplementation records rollout/sample spans for offline trajectory inspection. This draft records trainer-process and weight-sync phases with CUDA events and a shared run/rollout identity, so the two facilities are complementary rather than duplicate implementations. A fresh open issue/PR search found no equivalent trainer communication timeline.Compatibility and scope
--communication-timelineor its environment-variable equivalent is explicitly configuredValidation
tests/observability/test_communication_timeline.py,tests/test_empty_colocated_weight_bucket.py, andtests/test_megatron_argument_validation.py)py_compile; the rebased diff passedgit diff --checkLimitations
AI assistance disclosure
This draft was developed with OpenAI Codex assistance. The human submitter must review and understand every changed line and be prepared to defend the design and test coverage before marking it ready for review.