fix: cancel pending rollout tasks after a failure - #2350
Open
yuyz-cyber wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Training and evaluation launch rollout tasks concurrently at three levels: samples within a rollout group, rollout groups within a training batch, and samples within an evaluation batch.
When one task raises an exception, the exception is propagated but the unfinished sibling tasks are not cancelled. They can continue generation or reward computation after the rollout has failed, wasting resources and potentially leaving unobserved task exceptions in the event loop.
Fix
At each concurrency boundary, cancel unfinished sibling tasks and wait for their cleanup before re-raising the original exception. The training path also resets its shared generation state, and both training and evaluation close their progress bars before returning the failure. Successful rollout behavior is unchanged.
Test plan
tests/plugin_contracts/test_plugin_generate_contracts.py: 5 passed.tests/test_streaming_rollout.py: 26 passed.