fix: avoid reading correction settings when TIS is disabled - #2349
Open
yuyz-cyber wants to merge 1 commit into
Open
fix: avoid reading correction settings when TIS is disabled#2349yuyz-cyber wants to merge 1 commit into
yuyz-cyber wants to merge 1 commit into
Conversation
yuyz-cyber
force-pushed
the
fix/mis-metrics-without-tis
branch
from
September 4, 2026 07:43
d1ae592 to
ba2f887
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
--get-mismatch-metricsuses the examplecompute_mis_weights_with_cphelper with TIS disabled, training fails on the first batch:compute_mis_weightsreads the correction bounds before checkingargs.use_tis. These settings are not defined or used when TIS is disabled, so the premature access raises an exception and prevents the mismatch metrics from being returned.Fix
Move the correction-bound calculation after the
args.use_tischeck. Withuse_tis=False, the helper returns the mismatch metrics and original loss masks without accessing correction settings. The TIS-enabled path is unchanged.Test plan
use_tis=Falsewithout correction settings.tests/test_rollout_metrics.py: 12 passed.