Skip to content

fix: preserve equals in extra environment values - #2346

Open
imshunsuke wants to merge 1 commit into
THUDM:mainfrom
imshunsuke:fix-extra-env-var-equals
Open

fix: preserve equals in extra environment values#2346
imshunsuke wants to merge 1 commit into
THUDM:mainfrom
imshunsuke:fix-extra-env-var-equals

Conversation

@imshunsuke

Copy link
Copy Markdown

Summary

  • Preserve = characters after the first separator in the space-separated extra_env_vars fallback parser.
  • Add regression coverage to the always-on CPU test matrix.

Problem

_parse_extra_env_vars split each assignment on every = and then kept only the second component. For example:

TOKEN=abc== END=ok

was parsed as:

{"TOKEN": "abc", "END": "ok"}

This corrupts padded or otherwise =-containing environment values.

Change

Use split("=", 1) so only the key/value separator is consumed. JSON input handling and the existing fallback tokenization remain unchanged.

The new zero-GPU regression test is registered in the workflow template, and the generated workflow is updated with it.

Testing

  • tests/utils/test_command_utils.py: 1 passed
  • pre-commit run --all-files
  • Confirmed the generated pr-test.yml matches pr-test.yml.j2
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant