fix: preserve equals in extra environment values - #2346
Open
imshunsuke wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
=characters after the first separator in the space-separatedextra_env_varsfallback parser.Problem
_parse_extra_env_varssplit each assignment on every=and then kept only the second component. For example:TOKEN=abc== END=okwas parsed as:
{"TOKEN": "abc", "END": "ok"}This corrupts padded or otherwise
=-containing environment values.Change
Use
split("=", 1)so only the key/value separator is consumed. JSON input handling and the existing fallback tokenization remain unchanged.The new zero-GPU regression test is registered in the workflow template, and the generated workflow is updated with it.
Testing
tests/utils/test_command_utils.py: 1 passedpre-commit run --all-filespr-test.ymlmatchespr-test.yml.j2git diff --check