[XxFran10xX]

Summary

Faction menus show the new resource-pack vehicle icons (ServerAssets #80, COAL 7400-7421) through the existing icons: config:

• Berthed vehicles in an installation use vehicle_<type id>, falling back to the minecart.
• Installation kinds use installation_<kind>: port = sloop, airport = biplane, train station = locomotive. Forts keep green concrete (no entry). Name, lore and stored id are unchanged.
• Vehicle Pool button uses vehicle_pool (ironclad), falling back to the minecart.
• Default config.yml gets the 22 vehicle_<id> entries and the four above; default regiments.yml gives the Field Artillery regiment the field artillery icon instead of the BLACK_DYE 12 placeholder.

Live servers keep their own config.yml/regiments.yml, so the entries are added there by hand at push time. flat_car in vehicles.yml is left to #197, which adds it with the same values.

Testing

• Touched test classes pass (ArmyMenusCoverage 48, InstallationMenusCoverage 34, InstallationCreator 2, MilitaryViewDowngrade 3); new code is fully covered. The full local mvn verify hits the known Windows-only persistence failures that main also has here; CI is authoritative.
• Dev (TFMCDev01): the plugin loads with the new icon entries and no icon errors. The installation and pool menus need a faction with installations, so they were checked by unit tests rather than in game.

🤖 Generated with Claude Code

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 3e31a279-4257-4d9d-b2ac-31f46ea2d1ba

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}