Repository navigation
perf: refresh pickup lore only on items that can carry it, and set only changed slots - #76
Merged
Merged
Conversation
…ly changed slots Each pickup (once per player per tick since #75) ran both lore writers over all 41 inventory slots and set every slot back. For an ordinary item that meant about eight copies of its meta, its lore read twice and run through regexes (ArtifactLore.readAura), all to change nothing, and then a slot packet per slot. On Main at 15+ players that was ~3 s of main thread per hour. VesselLore now reads an item's meta once to tell whether a writer can touch it: aura or charge-tier data, a charge item match, or lore with a "/" (an aura line that readAura could read back). Other items come back unchanged, as both writers left them before. The inventory refresh sets a slot again only when its item changed; unchanged slots were only resent to the client. Lore output is the same: artifacts and charges still go through the same writers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review: both writers skip an item without meta, so do that first instead of looking up keys and charge matches on it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review: the plain-item test could not tell the skip from the old path, and MockBukkit's item factory never reports an empty meta. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. Summary
Merge Risk:
 |
github-actions
Bot
added
the
size:M
XxFran10xX
marked this pull request as ready for review
November 6, 2026 14:27
Contributor
Author
|
@coderabbitai full review |
Action performed
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Each pickup (once per player per tick since #75) ran both lore writers over all 41 inventory slots and set every slot back. For an ordinary item that meant about eight copies of its meta, its lore read twice and run through regexes (
ArtifactLore.readAura), all to change nothing, and then a slot packet per slot. On Main at 15+ players that was ~3 s of main thread per hour (spark 11-04).VesselLorenow reads an item's meta once to tell whether a writer can touch it: meta at all, aura or charge-tier data, a charge item match, or lore with a "/" (an aura linereadAuracould read back). Other items come back unchanged, as both writers left them before.Lore output is the same: artifacts and charges still go through the same writers.
Tests
VesselLoreTest: what can carry vessel lore, skipped items reach neither writer, only changed slots (charge, artifact) are set.Dev test
Dev (TFMCDev01, 11-05, Blood Magic Dev build + this change): pickups leave artifacts, ordinary items, a lored stick, Cooking food and STEEL_INGOT unchanged; a blank charge gets "Uncharged", a stamped charge "Charge / Mitlan II"; an artifact with its aura PDC stripped is rebuilt; no other slot changes.
🤖 Generated with Claude Code