Skip Node/TS subtrees and gitignored files in workspace validate#137
Open
zekelinAlex wants to merge 2 commits into
Open
Skip Node/TS subtrees and gitignored files in workspace validate#137zekelinAlex wants to merge 2 commits into
zekelinAlex wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #74.
workspace validatewas running Dataverse XSD/JSON validation againstevery file in the workspace, which produced a wall of false errors in
any repo with a PCF control or a TypeScript subproject. node_modules
contents, tsconfig.json, package-lock.json, eslintrc, you name it.
None of those are Dataverse metadata, but the validator didn't know.
Now the command filters before reporting:
Two escape hatches:
--no-ignoreturns everything off (originalbehaviour),
--no-gitignorekeeps defaults + node-project detectionbut ignores .gitignore.