refactor: migrate search CSS from Core-CMS to here - #555
Merged
wesleyboar merged 1 commit intoJul 31, 2026
Conversation
This makes it such that: 1. devs can update search styles without knowing about CMS branch 2. auto search page is not coupled to TACC search styles
wesleyboar
added a commit
that referenced
this pull request
Jul 31, 2026
….css Repoints the artscivis, cipp, craftlab, ctrn, and wtcs search snippets from Core-CMS's google-search.css to Core-CMS-Custom's own copy (pinned to the migration branch commit), completing the migration away from Core-CMS. Reverts the prior generic_assets change, since that file's content is now owned by the migration in #555. Related: #555 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
wesleyboar
deleted the
refactor/migrate-google-search-styles-from-core-cms-branch-to-core-cms-custom-main
branch
July 31, 2026 16:47
wesleyboar
added a commit
to TACC/Core-CMS
that referenced
this pull request
Jul 31, 2026
## Overview Replaces the local Google search styles with a CDN `@import` back to Core-CMS-Custom, now that it holds the actual styles. ## Related - [TACC/Core-CMS-Custom#555](TACC/Core-CMS-Custom#555) ## Changes - **replaced** `apps/search_page/static/search_page/css/google-search.css` contents with a CDN `@import` ## Testing Skipped. ## UI No visual change — styles are byte-identical to before, just sourced via CDN.
wesleyboar
added a commit
that referenced
this pull request
Jul 31, 2026
## Overview 1. Use Google Search styles now in this repo. 2. Point to latest copy of the styles (includes fixes). ## Related - #555 - TACC/Core-CMS#1218 - TACC/Core-CMS#1219 - inspired by #553 <sup>Dev tried to fix a problem by changing markup instead of CSS.</sup> ## Changes - **changed** URL for `google-search.css` ## Testing 0. Update a project to use new snippet markup. <sup>(e.g. artscivis, cipp, craftlab, ctrn, wtcs)</sup> 1. Visit a project's search page at a wide viewport (e.g. 1920px). 2. Verify: 1. gray search results header bkgd has no gaps 2. search results are centered --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
wesleyboar
added a commit
that referenced
this pull request
Aug 3, 2026
## Overview Use latest Google Search styles for TUP. ## Related - #555 - #557 - #554 ## Changes - **updated** snippet markup ## Testing 1. [TACC search](https://tacc.utexas.edu/search/?q=test) renders like [Texas CTRN search](https://texasctrn.org/search/?q=test). 1. [Snippet #89](https://tacc.utexas.edu/admin/djangocms_snippet/snippet/89/change/) content matches this diff. ## UI Skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Migrates Google Search styles from Core-CMS to here, Core-CMS-Custom.
Why?
So:
Related
Dev tried to fix a problem by changing markup instead of CSS.
Changes
@importwith the actual stylesTesting
generic_assets/css/google-search.cssat a wide viewport (e.g. 1920px)UI
Warning
Thumbnails are too far to right. Not good. Existing bug. Will fix.