Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR localizes the time units used in the "remaining time until alarm" display (e.g., "d", "h", "m", "now", "<1m").
Problem
The time units for the remaining duration display were hardcoded in the Kotlin source code (
NextAlarmCalculator.kt). This prevented these units from being translated and caused them to always appear in English regardless of the device's locale settings.Changes
NextAlarmCalculator.formatRemainingto accept aContextand use string resources for all units and status labels.app/src/main/res/values/strings.xml:time_unit_d(%1$dd)time_unit_now(now)time_unit_less_than_1m(<1m)time_unit_handtime_unit_m.formatRemainingto provide the necessaryContext:NextAlarmNotifier.ktAlarmListViewModel.ktAlarmEditOverviewSections.ktNextAlarmWidget.ktTesting
git diff --check: PASS