Handle shutdown state during supervisorctl preflight - #1724
Open
tianrking wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SHUTDOWN_STATEreturned by the sharedsupervisorctlpreflightFixes #48
Root cause
Every
supervisorctlcommand callsController.upcheck()before performing its action. The preflight recognizedUNKNOWN_METHOD, but re-raisedSHUTDOWN_STATE, soonecmd()formatted the known server lifecycle state as an internal exception with a Python file and line number. This is especially visible when a command followsreloadbefore the server has finished restarting.Tests
python -m pytest supervisor/tests/test_supervisorctl.py -q(199 passed on Linux)python -m compileall -q supervisorgit diff --check