docs + detectors + golden: surface Windows build, add blocker detectors, add decision cases - #14
Open
zeiddata-dev wants to merge 1 commit into
Open
Conversation
- docs: note the experimental unsigned Windows NSIS build in requirements - feat(detectors): add port, disk, docker, tls, and lock blockers - test(golden): add non-English and long multi-part decision cases
Contributor
Author
|
Heads up: CI is parked on the first-time-contributor approval gate, so no jobs have actually run on this yet (the failed run shows zero jobs). Whenever you get a sec, hit "Approve and run workflows" and it'll kick off. Nothing here needs secrets. Thanks. |
Owner
|
Truly an awesome review and initial support for this early stage project- thanks 100x for contributions! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small, self-contained changes from the review.
1. docs: update platform section
README Requirements now note the experimental unsigned Windows NSIS build that CI already produces (
windows-build.yml), instead of listing macOS only. It stands as an: unsigned, SmartScreen warns on first run, for manual testing.2. feat(detectors): five new blocker detectors
Same shape as the existing five, one regex each, deduped per (cwd, label):
EADDRINUSE/ address already in use)ENOSPC/ no space left on device)ELOCKED/ cache lock / could not get lock)3. test(golden): two new decision cases
Gaps in the current set: a non-English (Spanish) answered question, and a four-part ask with a partial answer (3 of 4 addressed).
Gates run locally
npx tsc --noEmit: clean.src/lib/extractor.ts. The golden suite shells out to the billedclaudeCLI, so it was not run here.clippyandcargo testare unaffected.