Skip to content

Surface cloud library action failures - #155

Open
SunkenInTime wants to merge 1 commit into
icarus-cloudfrom
agent/library-action-failures-98296362
Open

Surface cloud library action failures#155
SunkenInTime wants to merge 1 commit into
icarus-cloudfrom
agent/library-action-failures-98296362

Conversation

@SunkenInTime

@SunkenInTime SunkenInTime commented Sep 4, 2026

Copy link
Copy Markdown
Owner

What changed

  • make cloud folder update/delete/move and strategy delete/move return explicit action results
  • keep selections, pins, dialogs, and library streams unchanged unless the server action succeeds
  • keep edit/delete dialogs open for retry and block duplicate submissions while an action is running
  • route both cloud strategy export entry points through one failure boundary with silent cancellation and auth-incident handling
  • show concise player-facing errors while recording technical details separately

Verification

  • focused cloud library action suite: 21 passed
  • flutter test --no-pub: 621 passed, 2 intentional skips
  • flutter analyze --no-pub --no-fatal-infos: 0 errors/warnings, 35 existing info lints

Dependencies

None. This PR is based directly on icarus-cloud at b364914.

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 9f35e966-6caa-41a6-ad01-94e8a82f01af

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@SunkenInTime
SunkenInTime force-pushed the agent/library-action-failures-98296362 branch from 97db3e3 to 9666755 Compare September 4, 2026 05:22
@SunkenInTime

Copy link
Copy Markdown
Owner Author

@greptileai Please review current head 9666755 for cloud library action failure handling.

@greptile-apps

greptile-apps Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Cloud-library actions now wait for confirmed server outcomes before changing visible state. Focused provider and widget checks confirmed that failed deletes preserve pins, selections, and cloud views; folder edit and delete dialogs prevent duplicate requests and allow retry after failure; and cancelled or unauthenticated exports avoid an incorrect generic error message.

Confidence Score: 5/5

The verified cloud folder, strategy, dialog, and export failure paths are safe to merge.

Focused Flutter tests exercised rejected requests, pending requests, cancellation, unauthenticated failures, successful retry, and resulting UI state. All executed checks passed and no unresolved defect was identified in these paths.

Files Needing Attention: No additional files need attention for the verified behaviors.

T-Rex T-Rex Logs

What T-Rex did

  • Ran focused cloud-folder and cloud-strategy deletion tests and the full cloud-library action provider suite; all 10 tests passed and deletions preserved pins, selected-folder state, and cloud stream refresh counts.
  • Validated cloud deletion dialogs during in-flight requests; each dialog produced a single destructive call, showed a pending state, and allowed retry only after the initial failure completed.
  • Validated the real folder-edit dialog under an unresolved request, including a rapid second tap and a later successful retry, with the dialog staying open on failure and no folder or cloud-view changes in the failure case.
  • Ran focused widget tests for cloud_library_action_dialogs and confirmed both tests passed, verifying the delete-forcing flow and retry behavior.
  • Executed cancellation and authentication tests for cloud export paths; cancellation avoids the generic failure message and authentication uses the incident path as designed.

View all artifacts

T-Rex Ran code and verified through T-Rex

Reviews (2): Last reviewed commit: "fix: surface cloud library action failur..." | Re-trigger Greptile

@SunkenInTime

Copy link
Copy Markdown
Owner Author

The current head is 9666755. The prior review footer referenced 97db3e3. @greptileai Please review exact current head 9666755.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant