Keep account cloud outboxes visible and drainable - #153
Conversation
# Conflicts: # test/widgets/cloud_sync_status_chip_test.dart
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@greptileai Please review current head 9f43cbf for cloud outbox durability, account isolation, active-editor concurrency, and fail-closed sign-out behavior. |
9f43cbf to
327a862
Compare
|
Addressed the current-head attention-control audit in 327a862. Active conflict recovery remains available while the popover also identifies attention elsewhere in the Cloud library. Focused 127/127, full Flutter 686 passed with 2 intentional skips, analyze clean. @greptileai Please review the current head. |
Greptile SummaryThis change keeps eligible cloud work syncing after its editor closes, surfaces account-wide cloud work in the library and status chip, preserves explicit cloud-conflict choices, and routes sign-out through a retained-work check. Focused Flutter coverage verified account boundaries, serialized background and active syncing, exclusion of paused or rejected work from automatic retries, and sign-out blocking when active work is not durably retained. Confidence Score: 5/5The verified cloud-sync and sign-out paths are safe to merge. The reviewed behaviors were exercised with the repository-local Flutter SDK: a cross-account background-drain scenario, a held-request concurrency race, paused and rejected no-auto-run behavior, and a sign-out comparison showing that non-durable active media removes the confirmation action. Relevant queue, coordinator, Settings, and authentication test coverage passed. Files Needing Attention: No files need follow-up from the verified areas. The primary behavior remains concentrated in lib/providers/collab/strategy_op_queue_provider.dart and lib/services/cloud_sign_out_coordinator.dart.
What T-Rex did
Reviews (3): Last reviewed commit: "fix: surface and drain account cloud out..." | Re-trigger Greptile |
327a862 to
5bf2fc5
Compare
|
Addressed the Cloud-library visibility audit in 5bf2fc5. The account outbox banner now remains visible in owned and Shared With Me sections, while local and other-account work stay hidden. Full Flutter 687 passed with 2 intentional skips; focused shared/status coverage and analyze are clean. @greptileai Please review the current head. |
Summary
Sync guarantees
Verification
flutter test --no-pub(687 passed, 2 intentional skips)flutter analyze --no-pub(0 errors/warnings; 35 existing info lints)Stack dependency
This PR targets #145's branch at
bd402cc000cd58e3975fbca2a9fabfdc337f0d77. It merges the exact accepted #150 heade4b388b6f5966957676490301eb59c663bc400ca; #150 is stacked on #144. Merge order is therefore #144, #150, #145, then this PR (or rebase this PR after those dependencies land).