Close #1097, wrong sign-in loses execution context b/c missing nav detection#1100
Open
plocket wants to merge 5 commits into
Open
Close #1097, wrong sign-in loses execution context b/c missing nav detection#1100plocket wants to merge 5 commits into
plocket wants to merge 5 commits into
Conversation
excludes field values.‼️ NEVER USE REAL USERS' ANSWERS IN ALKILN TESTS. This HTML can still reveal information about a user's answers. For example, some answers will reveal new questions. That will change the code of the revealed fields and that code will be in the HTML. 🖊️ Before merging remove temporary debugging logs. Also breaks out the anonymous function in `Before()` to attempt better error tracing. Goal: try to repeat this for other functions in that file. Addresses #1097 in trying to see more information about our current test failure.
plocket
commented
Jun 28, 2026
| value: `ALKiln is unable to get any record of this page whatsoever, even the page HTML. Your server may be busy.` | ||
| }); | ||
| } | ||
| log.debug({ code: `ALK0282`, level: `note`, }, page_error ); |
Collaborator
Author
There was a problem hiding this comment.
Add a message to this error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also,
[I'm not completely sure these fixes address the symptoms I saw, namely all subsequent tests failing, but tests are consistently passing now. The fix of navigation ]
In this PR, I have:
Reason for this PR
[Waiting for navigation after signing in/failing to sign in and timing may have lined up just right in GitHub+You tests to trigger a failure when a user fails to log in. That, in combination with the disabled timeout and our dev server's setting to allow long loading times may have been enough to cause all of the subsequent tests to fail. I'm not completely sure because the tests should have kept running long enough for the server to recover, but I can no longer replicate the bug.
Replicating and digging might help us find out if adding a server health check to the sign-in Step could help at least give more helpful error messages. Maybe we should add a debug log in the server status check itself when the server isn't available. Maybe we already have it! Maybe we should fully log it to the authors.
Potential replication for further debugging: Maybe undoing the navigation detection and timeout handling would allow us to replicate the bug and dig deeper. I don't have a lot of time to give this right now, though.]
Links to any solved or related issues
Close #1097
Close #1099
Any manual testing I have done to ensure my PR is working
Manually triggered our GitHub+You tests several times (usually 10) to check for a repeat of the error.
Collaborators
Co-authored-by: fractalkitty 72811467+fractalkitty@users.noreply.github.com
Co-authored-by: Jamie Cash james.cash@occasionallycogent.com
Co-authored-by: cthulahoops adam@cthulahoops.org