Fix stale "ImagedBased" keys in Japanese translation#11986
Merged
Conversation
The code renamed ImagedBased -> ImageBased a while back, but three keys in Japanese.json still had the old misspelling, so those strings fell back to English in Japanese mode: * imagedBasedSubtitles -> imageBasedSubtitles * imagedBasedSubtitleForEditDotDotDot -> imageBasedSubtitleForEditDotDotDot * imagedBasedSubtitleForOcrDotDotDot -> imageBasedSubtitleForOcrDotDotDot Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three keys in
Japanese.jsonstill used the oldImagedBasedmisspelling after the code was renamed toImageBased, so those strings fell back to English in Japanese mode:imagedBasedSubtitles→imageBasedSubtitlesimagedBasedSubtitleForEditDotDotDot→imageBasedSubtitleForEditDotDotDotimagedBasedSubtitleForOcrDotDotDot→imageBasedSubtitleForOcrDotDotDotOnly the key names changed (values untouched); JSON still validates.
Spotted while analyzing discussion #10742. The same typo is in hisui3393's source file, so it would reappear on the next sync unless fixed upstream too.
🤖 Generated with Claude Code