Adjust all times: add independent extend start/end option (#11602)#11983
Open
muaz978 wants to merge 1 commit into
Open
Adjust all times: add independent extend start/end option (#11602)#11983muaz978 wants to merge 1 commit into
muaz978 wants to merge 1 commit into
Conversation
…it#11602) Adds an "Extend duration" section to the Adjust all times dialog that grows each line's duration by moving the start earlier and/or the end later, leaving the opposite edge fixed. This complements the existing show earlier/later buttons, which shift the whole line. The two amounts are independent, persist across sessions, and respect the same All / Selected / Selected-and-forward scope as the existing buttons. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjust all times: independent extend start/end
Implements suggestion #1 from #11602.
Problem
The Adjust all times dialog only offers "Show earlier" / "Show later", which shift the whole line (start and end move together by the same amount). There was no way to grow a line's duration by pulling only its start earlier or pushing only its end later.
Change
Adds an "Extend duration (independent start/end)" section to the dialog:
The existing "Show earlier" / "Show later" behaviour is unchanged.
Implementation notes
IAdjustCallback.ExtendStartEndTimes(...)implemented inMainViewModel, applying the edit atomically viaSubtitleLineViewModel.SetTimes(recomputes duration, never exposes start greater than end). A start that would go negative is clamped to zero.ExtendStartEarlier/ExtendEndLaterobservable properties, anExtendcommand, and load/save of the two new settings.Files
src/ui/Logic/Config/SeAdjustAllTimes.cssrc/ui/Features/Sync/AdjustAllTimes/IAdjustCallback.cssrc/ui/Features/Sync/AdjustAllTimes/AdjustAllTimesViewModel.cssrc/ui/Features/Sync/AdjustAllTimes/AdjustAllTimesWindow.cssrc/ui/Features/Main/MainViewModel.cssrc/ui/Logic/Config/Language/Sync/LanguageSync.cs🤖 Generated with Claude Code