Add grid click action "Go to subtitle and play and focus text box" (#11602)#11981
Open
muaz978 wants to merge 1 commit into
Open
Add grid click action "Go to subtitle and play and focus text box" (#11602)#11981muaz978 wants to merge 1 commit into
muaz978 wants to merge 1 commit into
Conversation
…ubtitleEdit#11602) The single-click and double-click grid action lists offered "go to subtitle and pause and focus text box", but not a play-and-focus variant. This lets the video keep playing while the caret moves into the edit box, so the text can be edited without stopping playback. Adds the GoToSubtitleAndPlayAndFocusTextBox value to both the single- and double-click action enums, handlers, settings combo boxes and the action/label maps, plus the language string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #11602 (suggestion 2).
The single-click and double-click grid action lists offered a pause-and-focus variant but not a play-and-focus one. This adds Go to subtitle and play and focus text box to both, so the video keeps playing while the caret moves into the edit box (edit text without stopping playback).
Wires the new value through both click-action enums, both handlers, the settings combo boxes, the action/label maps, and the language string.