Fix "go to next/previous subtitle from video position" skipping lines (#11602)#11970
Merged
niksedk merged 1 commit intoJun 29, 2026
Conversation
…SubtitleEdit#11602) Navigation picked the first following line with duration < 10s (a heuristic to avoid landing on long ASSA background-effect lines). But that skipped any ordinary caption >= 10s and jumped to a later, shorter line - so users saw the "next subtitle" command leap over several lines. Go to the immediately adjacent line instead, and only skip a line when it is a genuine background effect: >= 10s long AND overlapping the following line. A fallback still selects the first/last line if everything qualifies. Applied to both the next and previous commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #11602.
Navigation picked the first following line with duration under 10s (a heuristic to avoid landing on long ASSA background-effect lines), which skipped any ordinary caption of 10s or longer and jumped to a later short line, so users saw "next subtitle" leap over several lines.
Now go to the immediately adjacent line, and only skip a line when it is a genuine background effect: 10s or longer AND overlapping the following line. A fallback still selects the first or last line if everything qualifies. Applied to both next and previous.