Skip to content

[20.0][FIX] base_user_role: preserve role sequence and write values #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pierre-pizzetta wants to merge 1 commit into from
Closed

[20.0][FIX] base_user_role: preserve role sequence and write values #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions base_user_role/models/role.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,13 @@ def read(self, fields=None, load="_classic_read"):

def write(self, vals):
recs = self.sudo() if self._bypass_rules() else self
vals = dict(vals)
# Workaround to solve issue with broken code in odoo that clear the
# cache during the write: see odoo/addons/base/models/res_users.py#L226
groups_vals = {}
for field in recs.group_id._fields:
if field in vals:
groups_vals[field] = vals.pop(field)
for name, field in recs._fields.items():
if field.inherited and name in vals:
groups_vals[name] = vals.pop(name)
if groups_vals:
recs.group_id.write(groups_vals)
res = super(ResUsersRole, recs).write(vals)
Expand Down
12 changes: 12 additions & 0 deletions base_user_role/tests/test_user_role.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,18 @@ def setUpClass(cls):


class TestUserRole(TestUserRoleCommon):
def test_role_sequence(self):
group_sequence = self.role1_id.group_id.sequence
self.role1_id.write({"sequence": 42})
self.assertEqual(self.role1_id.sequence, 42)
self.assertEqual(self.role1_id.group_id.sequence, group_sequence)

def test_role_write_preserves_values(self):
values = {"name": "Renamed role"}
self.role1_id.write(values)
self.assertEqual(self.role1_id.name, "Renamed role")
self.assertEqual(values, {"name": "Renamed role"})

def test_role_1(self):
self.user_id.write(
{"role_line_ids": [fields.Command.create({"role_id": self.role1_id.id})]}
Expand Down