Repository navigation
Report the editor as ready after refresh_unity's server-side wait - #63
Merged
Merged
Conversation
On Unity 6 the plugin answers compile="request" as soon as the compile starts, because its own readiness wait cannot span the domain reload. refresh_unity then waited for readiness on the server but returned the plugin's reply unchanged, so a call that had waited still said resulting_state "compiling" and told the caller to poll (#45). Once the server-side wait confirms readiness, report resulting_state "idle" with the ready hint. Other fields, including compile_started, are kept. Without wait_for_ready the reply is unchanged. Upstream v10.3.0 (a0f59c2 and follow-ups) already makes the plugin reply only after the compile has started, so the server's wait covers the whole compile. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45. This is the part upstream v10.3.0 left open.
Upstream v10.3.0 (merged in #61) makes the plugin reply only after a requested compile has started, so
refresh_unity's server-side wait now covers the whole compile. On Unity 6, though, the tool still returned the plugin's mid-compile reply after that wait:resulting_state: "compiling"and a hint to pollmcpforunity://editor/state. A caller couldn't tell that the wait had happened.Once the server-side wait confirms readiness, the reply now reports
resulting_state: "idle"with the ready hint. Other fields, includingcompile_started, are kept. Withoutwait_for_readythe reply is unchanged.Tests: new
Server/tests/integration/test_refresh_unity_wait_reply.py, seen failing before the fix.🤖 Generated with Claude Code