Repository navigation
Prepend the server launch's PATH through the inherited entry - #62
Merged
Merged
Conversation
StartLocalHttpServer wrote its uv/uvx PATH prepend to EnvironmentVariables["PATH"]. Mono's EnvironmentVariables is case-sensitive and Windows spells the inherited entry "Path", so the prepend went into a second entry and the server resolved commands with the original (#52). Route it through ExecPath.SetPathVariable, which upstream added for TryRun and FindInPathWindows and which writes through the existing entry whatever its casing. The new EditMode test gives the inherited entry the Windows spelling and failed before the fix with "got: PATH, Path". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #52. This is the part upstream v10.3.0 left open.
Upstream da91669 (merged in #61) added
ExecPath.SetPathVariable, which writesPATHthrough whatever spelling the inherited environment uses. It also routedExecPath.TryRunandExecPath.FindInPathWindowsthrough it.ServerManagementService.StartLocalHttpServerstill wroteEnvironmentVariables["PATH"]directly. On Windows the inherited entry isPath, and Mono's dictionary is case-sensitive, so the uv/uvx prepend for the server launch went into a second entry the server never read. The launch now goes throughSetPathVariable, which becomesinternal.Tests: new EditMode
StartLocalHttpServer_PathPrepend_WritesThroughTheInheritedPathEntrygives the inherited entry the Windows spelling. It was seen failing before the fix.🤖 Generated with Claude Code