[vbucc]

Description

On Windows, the local HTTP server started from an editor kept that editor's Logs/Editor.log locked for the server's whole life. Every later editor of the project then fell back to the machine-global Editor.log (#50).

The cause is Mono's Process.Start: it calls CreateProcessW with bInheritHandles hard-coded TRUE. So the launch process (cmd, then uvx, uv and python) got a copy of every inheritable handle the editor held, including its open log.

The server launch now goes through ServerProcessLauncher, which makes the same CreateProcessW call with inheritance off.

Fixes #50

Type of Change

• Bug fix (non-breaking change that fixes an issue)
• Test update

Changes Made

• New MCPForUnity/Editor/Services/Server/ServerProcessLauncher.cs, which on Windows makes Mono's CreateProcessW call with these differences:
  • bInheritHandles = FALSE.
  • No std handles are passed, so cmd uses its own hidden console's.
  • The process is created suspended, so Process.GetProcessById gets its handle before the process can exit. That handle is then made non-inheritable, as Process.Start's is.
  • Unchanged from Mono: the command line and the environment block, built from EnvironmentVariables in the same order.
  • Off Windows it is Process.Start: Mono closes descriptors above 2 in a POSIX child, so nothing leaks there.
  • Its contract holds on every platform: UseShellExecute, redirects, UserName and ArgumentList throw NotSupportedException instead of being silently dropped.
• ServerManagementService.StartLocalHttpServer: a one-line change to call the launcher.
• New ServerProcessLauncherTests (Windows cases use Assert.Ignore elsewhere):
  • The launched process holds no copy of an inheritable editor handle, checked with the Restart Manager. Red on Process.Start.
  • The returned handle is not inheritable. Red without the SetHandleInformation call.
  • cd & set output is identical to Process.Start's: working directory and environment.
  • Unsupported fields throw NotSupportedException.
• Version bumped to 10.2.0-fork.2.

Behaviour changes (Windows)

• The server no longer inherits any editor handle. This is the fix.
• cmd's own messages go to its hidden console, not to the editor's std handles, which a GUI editor does not have. The server's output still goes to the launch log through the existing < NUL >> log 2>&1.
• A start info whose EnvironmentVariables was never touched now passes a snapshot of the editor's environment, without Windows' hidden =C: drive entries. The production launch always touches it (the uv PATH prepend), so only the characterization fake (cmd /c exit) takes this path.

Compatibility / Package Source

• Unity version(s) tested: 6000.5.5f1 (Windows 11)
• Package source used: file: (TestProjects/UnityMCPTests)

Testing

• Unity EditMode tests
  • Local gate: python tools/local_harness.py --legs editmode gave 1035/1114 passed, 0 failed.
  • Direct batchmode run of ServerProcessLauncherTests, ServerManagementServiceCharacterizationTests and TerminalLauncherTests: 72/72 passed.
• Python tests: not applicable, Server/ is untouched.

Related Issues

Fixes #50

Additional Notes

• A server that is already running keeps its inherited handle until it is restarted from an editor that has this version.
• An IDE started from Unity (for example VS Code, through com.unity.ide.visualstudio) can still hold the log the same way. That launch is outside this package.

🤖 Generated with Claude Code

https://claude.ai/code/session_018mVoikeBS5RijnEmvTr8RR