Skip to content

fix: bind using directly to constructed TestConsole (cs/local-not-disposed) #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StuartMeeks merged 1 commit into from
Aug 22, 2026
Merged

fix: bind using directly to constructed TestConsole (cs/local-not-disposed) #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
`char.IsAsciiHexDigit`, which is available on both shipped target frameworks and reads
as the intent. The two `TestConsole` instances in `SplashScreenTests` are now disposed
via `using` (`cs/local-not-disposed`); `TestConsole` is `IDisposable` and both were
leaking. No behaviour, public API or rendered output changed.
leaking. The `Width(120)` call is now a separate statement rather than chained into the
`using` initializer, so the `using` binds directly to the constructed console — CodeQL
cannot prove a fluent method returns its receiver, so the chained form left the
construction flagged as undisposed. No behaviour, public API or rendered output changed.

### Changed

Expand Down
3 changes: 2 additions & 1 deletion tests/NextIteration.SpectreConsole.Splash.Tests/SplashScreenTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ public void Show_writes_to_AnsiConsole()
public void Show_with_custom_tagline_emits_it()
{
var prev = AnsiConsole.Console;
using var test = new TestConsole().Width(120);
using var test = new TestConsole();
test.Width(120);
AnsiConsole.Console = test;
try
{
Expand Down