Skip to content

chore: adopt latest standards — gate house style in-build (§1.2.1, §5.2, §4.4, §2.7) - #13

Merged
StuartMeeks merged 1 commit into
mainfrom
chore/adopt-latest-standards
Aug 21, 2026
Merged

chore: adopt latest standards — gate house style in-build (§1.2.1, §5.2, §4.4, §2.7)#13
StuartMeeks merged 1 commit into
mainfrom
chore/adopt-latest-standards

Conversation

@StuartMeeks

Copy link
Copy Markdown
Owner

Catches this repo up to the NextIteration.Standards
changes landed 2026-08-21, after Splash's 2026-08-20 adoption reached 29/29.

Standards conformance only — this is not a release. <Version> stays 0.3.0 and the
CHANGELOG entries sit under [Unreleased]. Cutting 1.0.0 (version bump + tag) is left for
whenever the maintainer decides.

Changes

  • §1.2.1EnforceCodeStyleInBuild=true (via the canonical Directory.Build.props).
  • §5.2 — canonical .editorconfig: a deliberate allow-list of named style gates
    (braces always, var, System-first usings, full naming ruleset), byte-identical to the
    template.
  • §4.4codeql.yml gains the query-filters block excluding cs/unmanaged-code and
    cs/call-to-unmanaged-code. No P/Invoke here, so it matches nothing; carried so the
    workflow stays identical to the template (§3.0.1).
  • §2.7 — test project (and the demo, same conflict) add IDE0005 to NoWarn.
  • Code brought to green under the flag: braces, var, using order, single-line
    expression bodies in tests, removal of gratuitous _ = discards per the estate house
    rule. Behaviour-preserving — no public API or rendered output changed; the single
    AnsiConsole.Markup render path and its markup escaping are untouched.

Verification

  • dotnet build -c Release: 0 warnings, 0 errors under TreatWarningsAsErrors +
    EnforceCodeStyleInBuild.
  • dotnet test -c Release: 80 passed, 0 failed (40 × net8.0 + 40 × net10.0).

Follow-up (not in this PR)

  • §4.12 (CodeQL-gates-merge: require the analyze check + a code_scanning
    merge-protection rule) is branch-protection config, not a file change — needs
    apply-repo-settings.sh --with-required-checks, a maintainer action.

🤖 Generated with Claude Code

….2, §4.4, §2.7)

Catches this repo up to the NextIteration.Standards changes landed 2026-08-21, after
Splash's 2026-08-20 adoption reached 29/29. No release: <Version> stays 0.3.0 and the
CHANGELOG entries sit under [Unreleased].

- §1.2.1 EnforceCodeStyleInBuild=true, via the canonical Directory.Build.props.
- §5.2 canonical .editorconfig — a deliberate allow-list of named style gates (braces
  always, var throughout, System-first usings, full naming ruleset), no blanket
  severity. Byte-identical to the template.
- §4.4 codeql.yml gains the query-filters block excluding cs/unmanaged-code and
  cs/call-to-unmanaged-code. This repo has no P/Invoke, so it matches nothing here;
  carried so the workflow stays identical to the estate template (§3.0.1).
- §2.7 the test project (and the demo, which hits the same conflict) add IDE0005 to
  NoWarn — it would otherwise hard-error demanding GenerateDocumentationFile once the
  flag gates it as a warning.

Library, test and demo code brought to green under the flag: braces, var, using order,
single-line expression bodies in tests, and removal of gratuitous `_ =` discards per
the estate house rule. Behaviour-preserving — no public API or rendered output changed;
the single-AnsiConsole.Markup render path and its markup escaping are untouched. Build
clean at zero warnings; 80 tests (40 × net8.0/net10.0) pass on all three platforms.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@StuartMeeks
StuartMeeks merged commit ef190f6 into main Aug 21, 2026
9 checks passed
@StuartMeeks
StuartMeeks deleted the chore/adopt-latest-standards branch August 21, 2026 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant