chore: adopt latest standards — gate house style in-build (§1.2.1, §5.2, §4.4, §2.7) - #13
Merged
Merged
Conversation
….2, §4.4, §2.7) Catches this repo up to the NextIteration.Standards changes landed 2026-08-21, after Splash's 2026-08-20 adoption reached 29/29. No release: <Version> stays 0.3.0 and the CHANGELOG entries sit under [Unreleased]. - §1.2.1 EnforceCodeStyleInBuild=true, via the canonical Directory.Build.props. - §5.2 canonical .editorconfig — a deliberate allow-list of named style gates (braces always, var throughout, System-first usings, full naming ruleset), no blanket severity. Byte-identical to the template. - §4.4 codeql.yml gains the query-filters block excluding cs/unmanaged-code and cs/call-to-unmanaged-code. This repo has no P/Invoke, so it matches nothing here; carried so the workflow stays identical to the estate template (§3.0.1). - §2.7 the test project (and the demo, which hits the same conflict) add IDE0005 to NoWarn — it would otherwise hard-error demanding GenerateDocumentationFile once the flag gates it as a warning. Library, test and demo code brought to green under the flag: braces, var, using order, single-line expression bodies in tests, and removal of gratuitous `_ =` discards per the estate house rule. Behaviour-preserving — no public API or rendered output changed; the single-AnsiConsole.Markup render path and its markup escaping are untouched. Build clean at zero warnings; 80 tests (40 × net8.0/net10.0) pass on all three platforms. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catches this repo up to the NextIteration.Standards
changes landed 2026-08-21, after Splash's 2026-08-20 adoption reached 29/29.
Standards conformance only — this is not a release.
<Version>stays0.3.0and theCHANGELOG entries sit under
[Unreleased]. Cutting 1.0.0 (version bump + tag) is left forwhenever the maintainer decides.
Changes
EnforceCodeStyleInBuild=true(via the canonicalDirectory.Build.props)..editorconfig: a deliberate allow-list of named style gates(braces always,
var,System-first usings, full naming ruleset), byte-identical to thetemplate.
codeql.ymlgains thequery-filtersblock excludingcs/unmanaged-codeandcs/call-to-unmanaged-code. No P/Invoke here, so it matches nothing; carried so theworkflow stays identical to the template (§3.0.1).
IDE0005toNoWarn.var, using order, single-lineexpression bodies in tests, removal of gratuitous
_ =discards per the estate houserule. Behaviour-preserving — no public API or rendered output changed; the single
AnsiConsole.Markuprender path and its markup escaping are untouched.Verification
dotnet build -c Release: 0 warnings, 0 errors underTreatWarningsAsErrors+EnforceCodeStyleInBuild.dotnet test -c Release: 80 passed, 0 failed (40 ×net8.0+ 40 ×net10.0).Follow-up (not in this PR)
analyzecheck + acode_scanningmerge-protection rule) is branch-protection config, not a file change — needs
apply-repo-settings.sh --with-required-checks, a maintainer action.🤖 Generated with Claude Code