release: 1.0.0 — first stable release + latest standards catch-up - #12
Closed
StuartMeeks wants to merge 3 commits into
Closed
release: 1.0.0 — first stable release + latest standards catch-up#12StuartMeeks wants to merge 3 commits into
StuartMeeks wants to merge 3 commits into
Conversation
….2, §4.4, §2.7) Catches this repo up to the NextIteration.Standards changes landed 2026-08-21, after Splash's 2026-08-20 adoption reached 29/29: - §1.2.1 EnforceCodeStyleInBuild=true, via the canonical Directory.Build.props. - §5.2 canonical .editorconfig — a deliberate allow-list of named style gates (braces always, var throughout, System-first usings, full naming ruleset), no blanket severity. Byte-identical to the template. - §4.4 codeql.yml gains the query-filters block excluding cs/unmanaged-code and cs/call-to-unmanaged-code. This repo has no P/Invoke, so it matches nothing here; carried so the workflow stays identical to the estate template (§3.0.1). - §2.7 the test project (and the demo, which hits the same conflict) add IDE0005 to NoWarn — it would otherwise hard-error demanding GenerateDocumentationFile once the flag gates it as a warning. Library, test and demo code brought to green under the flag: braces, var, using order, expression bodies in tests, and removal of gratuitous `_ =` discards per the estate house rule. Behaviour-preserving — no public API or rendered output changed; the single-AnsiConsole.Markup render path and its markup escaping are untouched. Build clean at zero warnings; 80 tests (40 × net8.0/net10.0) pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Bumps <Version> to 1.0.0 and dates the CHANGELOG section. No public API changed: 1.0.0 is a stability commitment over the 0.3.0 surface (SplashScreen, SplashOptions, SplashColors, SplashTagline), following SemVer from a 1.0 baseline, released together with the accumulated standards-conformance work since 0.3.0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
dotnet format had converted Pool_has_at_least_100_entries to an expression body with its two explanatory comments wedged between `=>` and the `Assert.True(...)`. Windows' Roslyn rejected that layout under IDE0055 (Linux/macOS accepted it), while IDE0022 still demands the expression body because the sole body statement is single-line. Moving the comments above the method and keeping the expression on one line satisfies both rules on every platform. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Owner
Author
|
Superseded by the standards-only chore PR from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First stable release of
NextIteration.SpectreConsole.Splash, bundled with thestandards-conformance work landed in
NextIteration.Standards on
2026-08-21 (after this repo's 2026-08-20 adoption reached 29/29).
Standards catch-up
EnforceCodeStyleInBuild=true(via the canonicalDirectory.Build.props)..editorconfig, a deliberate allow-list of named style gates(braces always,
var,System-first usings, full naming ruleset), byte-identical tothe template.
codeql.ymlgains thequery-filtersblock excludingcs/unmanaged-codeand
cs/call-to-unmanaged-code. No P/Invoke here, so it matches nothing; carried so theworkflow stays identical to the template (§3.0.1).
IDE0005toNoWarn.var, using order, expression bodiesin tests, and removal of gratuitous
_ =discards per the estate house rule.Behaviour-preserving — no public API or rendered output changed; the single
AnsiConsole.Markuprender path and its markup escaping are untouched.Release
<Version>→ 1.0.0. No API change; a stability commitment over the 0.3.0 surface,following SemVer from a 1.0 baseline.
CHANGELOG.md[Unreleased]promoted to[1.0.0] — 2026-08-21, gathering everythingsince 0.3.0; compare links updated.
Verification
dotnet build -c Release: 0 warnings, 0 errors underTreatWarningsAsErrors+EnforceCodeStyleInBuild.dotnet test -c Release: 80 passed, 0 failed (40 ×net8.0+ 40 ×net10.0)..nupkg/.snupkgpack cleanly.Not in this PR (repo-settings / human actions)
analyzecheck + acode_scanningmerge-protection rule) is branch-protection config, not a file change — it needs
apply-repo-settings.sh --with-required-checksor the API, and changing branchprotection is a maintainer action. Flagged for follow-up.
v1.0.0tag (which triggers thepublishjob) is left for the maintainer.🤖 Generated with Claude Code