Align ci.yml with the canonical template exactly - #13
Merged
Conversation
Removes the `release` job. ci.yml's non-comment content is now identical to templates/.github/workflows/ci.yml apart from the tag glob, which makes it identical to SelfUpdate's -- verified by diff, not by eye. This repo was the estate's only divergence from the canonical workflow. Auth and SelfUpdate already matched the template: SelfUpdate exactly, Auth with one gnome-keyring step that has an EXCEPTIONS.md entry. That alignment was real and achieved, and this repo was quietly outside it while the audit reported green, because 3.0 checks filenames and 3.1 checks job names and nothing checked what actually runs. Two earlier attempts at this made it worse. The first widened 3.1 to permit any tag-gated job downstream of `publish` -- weakening a clause so a repo passes, which is the one thing the standards repo exists to stop. The second folded the release steps into `publish`, which kept the four job names and moved the divergence somewhere no check looked. Both are reverted; the job is simply gone. GitHub releases for this package are now cut by hand, as they already were in all four other repos. No consumer impact: the job only ever ran on a v* tag, after the package had already been pushed to nuget.org. Publishing is untouched. STANDARD.md 3.0.1 now requires this match and audit-drift.sh checks it. Verified against both wrong attempts: with the release job, and with the folded steps, 3.0 and 3.1 stay PASS while 3.0.1 goes FAIL. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Removes the
releasejob.ci.yml's non-comment content is now identical totemplates/.github/workflows/ci.ymlapart from the tag glob — which makes it identical to SelfUpdate's, verified by diff rather than by eye.Why
This repo was the estate's only divergence from the canonical workflow, and I only noticed because you pushed back. Auth and SelfUpdate already matched the template — SelfUpdate exactly, Auth with one
gnome-keyringstep that has anEXCEPTIONS.mdentry. That alignment was real and achieved. Settings sat outside it while the audit reported green, because §3.0 checks filenames, §3.1 checks job names, and nothing checked what actually runs.Two earlier attempts at reconciling this made it worse, and both are reverted:
publish— weakening a clause so a repo passes, which is the one thing the standards repo exists to stop.publish— kept the four job names and moved the divergence somewhere no check looked.The job is simply gone.
Consumer impact
None. The job only ever ran on a
v*tag, after the package had already been pushed to nuget.org. Publishing is untouched — samepublishjob, same trusted-publishing OIDC flow, same artifact.The behaviour change is operational, not consumer-facing: GitHub releases for this package are now cut by hand, as they already were in all four other repos.
Enforcement
STANDARD.md§3.0.1 (in Standards) now requires this match, andaudit-drift.shhas a3.0.1 workflow contentrow that checks it.Verified against both wrong attempts — with the
releasejob, and with the folded steps,3.0and3.1stay PASS while3.0.1goes FAIL:Checklist
CHANGELOG.mdupdated under[Unreleased]🤖 Generated with Claude Code