Skip to content

fix: resolve cs/dereferenced-value-may-be-null in ListCredentialsAsync #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StuartMeeks merged 1 commit into from
Aug 22, 2026
Merged

fix: resolve cs/dereferenced-value-may-be-null in ListCredentialsAsync #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
every target framework at once, where autobuild could pick a single TFM and analyse half
the code. Adopts the revised canonical `codeql.yml` verbatim; no query coverage changes.

- **Rewrote the provider-match guard in `FileCredentialManager.ListCredentialsAsync`**
from `credential?.ProviderName.Equals(…) == true` to an explicit
`credential is not null && …`. Behavior is identical, but the null state now flows into
the block body — which dereferences `credential` throughout — so both the compiler and
CodeQL can prove the accesses safe. Resolves the `cs/dereferenced-value-may-be-null`
alert the corrected buildless analysis surfaced (a genuine code fix, not a dismissal).

## [1.0.0] — 2026-08-21

First stable release. Headline: whole-store **export/import** to move credentials
Expand Down
6 changes: 5 additions & 1 deletion src/NextIteration.SpectreConsole.Auth/Persistence/FileCredentialManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,11 @@ public async Task<IEnumerable<CredentialSummary>> ListCredentialsAsync(string pr
// Defensive re-check: the glob should only match this
// provider's files, but if a stray file sneaks in we want
// to ignore it rather than report a mis-attributed row.
if (credential?.ProviderName.Equals(providerName, StringComparison.OrdinalIgnoreCase) == true)
// `is not null` (rather than `?.… == true`) so the null
// state flows into the block — the whole body dereferences
// `credential`, and this lets the analyzer prove it safe.
if (credential is not null &&
credential.ProviderName.Equals(providerName, StringComparison.OrdinalIgnoreCase))
{
var isSelected = selections.TryGetValue($"{credential.ProviderName}", out var selectedId) &&
selectedId.Equals(credential.AccountId, StringComparison.OrdinalIgnoreCase);
Expand Down